ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-13 03:28:33 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove duplicate AzureResource enum (#18501)

Browse Source 
* Remove duplicate AzureResource enum

* comment
This commit is contained in:
Charles Gagnon
2022-02-28 12:19:38 -08:00
committed by GitHub
parent 7b5117b185
commit 3b4800de51
5 changed files with 6 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/sql/platform/accounts/common/interfaces.ts
View File

@@ -47,22 +47,6 @@ export interface IAccountManagementService {
readonly updateAccountListEvent: Event<UpdateAccountListEventParams>;
}
// API sqlExtHostTypes.ts > AzureResource should also be updated
// Enum matching the AzureResource enum from azdata.d.ts
export enum AzureResource {
ResourceManagement = 0,
Sql = 1,
OssRdbms = 2,
AzureKeyVault = 3,
Graph = 4,
MicrosoftResourceManagement = 5,
AzureDevOps = 6,
MsGraph = 7,
AzureLogAnalytics = 8,
AzureStorage = 9,
AzureKusto = 10
}
export interface IAccountStore {
/**
* Adds the provided account if the account doesn't exist. Updates the account if it already exists

1
src/sql/workbench/api/common/sqlExtHostTypes.ts
View File

@@ -430,7 +430,6 @@ export class TreeComponentItem extends vsExtTypes.TreeItem {
checked?: boolean;
}
// Accounts interfaces.ts > AzureResource should also be updated
export enum AzureResource {
ResourceManagement = 0,
Sql = 1,

4
src/sql/workbench/services/connection/browser/connectionManagementService.ts
View File

@@ -23,8 +23,8 @@ import * as TelemetryKeys from 'sql/platform/telemetry/common/telemetryKeys';
import { IResourceProviderService } from 'sql/workbench/services/resourceProvider/common/resourceProviderService';
import { IAngularEventingService, AngularEventType } from 'sql/platform/angularEventing/browser/angularEventingService';
import { Deferred } from 'sql/base/common/promise';
import { ConnectionOptionSpecialType } from 'sql/workbench/api/common/sqlExtHostTypes';
import { IAccountManagementService, AzureResource } from 'sql/platform/accounts/common/interfaces';
import { AzureResource, ConnectionOptionSpecialType } from 'sql/workbench/api/common/sqlExtHostTypes';
import { IAccountManagementService } from 'sql/platform/accounts/common/interfaces';
import * as azdata from 'azdata';

3
src/sql/workbench/services/resourceProvider/browser/firewallRuleDialogController.ts
View File

@@ -10,10 +10,11 @@ import * as azdata from 'azdata';
import { IConnectionProfile } from 'sql/platform/connection/common/interfaces';
import { FirewallRuleDialog } from 'sql/workbench/services/resourceProvider/browser/firewallRuleDialog';
import { IAccountManagementService, AzureResource } from 'sql/platform/accounts/common/interfaces';
import { IAccountManagementService } from 'sql/platform/accounts/common/interfaces';
import { IResourceProviderService } from 'sql/workbench/services/resourceProvider/common/resourceProviderService';
import { Deferred } from 'sql/base/common/promise';
import { IErrorMessageService } from 'sql/platform/errorMessage/common/errorMessageService';
import { AzureResource } from 'sql/workbench/api/common/sqlExtHostTypes';
export class FirewallRuleDialogController {

3
src/sql/workbench/test/electron-browser/api/extHostAccountManagement.test.ts
View File

@@ -12,9 +12,10 @@ import { TestInstantiationService } from 'vs/platform/instantiation/test/common/
import { IRPCProtocol } from 'vs/workbench/services/extensions/common/proxyIdentifier';
import { SqlMainContext } from 'sql/workbench/api/common/sqlExtHost.protocol';
import { MainThreadAccountManagement } from 'sql/workbench/api/browser/mainThreadAccountManagement';
import { IAccountManagementService, AzureResource } from 'sql/platform/accounts/common/interfaces';
import { IAccountManagementService } from 'sql/platform/accounts/common/interfaces';
import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
import { TestRPCProtocol } from 'vs/workbench/test/browser/api/testRPCProtocol';
import { AzureResource } from 'sql/workbench/api/common/sqlExtHostTypes';
const IRPCProtocol = createDecorator<IRPCProtocol>('rpcProtocol');