Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898 (#15681)

* Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898

* Fixes and cleanup

* Distro

* Fix hygiene yarn

* delete no yarn lock changes file

* Fix hygiene

* Fix layer check

* Fix CI

* Skip lib checks

* Remove tests deleted in vs code

* Fix tests

* Distro

* Fix tests and add removed extension point

* Skip failing notebook tests for now

* Disable broken tests and cleanup build folder

* Update yarn.lock and fix smoke tests

* Bump sqlite

* fix contributed actions and file spacing

* Fix user data path

* Update yarn.locks

Co-authored-by: ADS Merger <karlb@microsoft.com>

extensions/mssql/src/objectExplorerNodeProvider/cancelableStream.ts

@@ -14,7 +14,7 @@ export class CancelableStream extends Transform {
 		super();
 	}
 
-	public _transform(chunk: any, encoding: string, callback: Function): void {
+	public override _transform(chunk: any, encoding: string, callback: Function): void {
 		if (this.cancelationToken && this.cancelationToken.token.isCancellationRequested) {
 			callback(new Error(localize('streamCanceled', "Stream operation canceled by the user")));
 		} else {

extensions/mssql/src/objectExplorerNodeProvider/command.ts

@@ -71,7 +71,7 @@ export abstract class Command extends vscode.Disposable {
 		this.disposable = vscode.Disposable.from(...subscriptions);
 	}
 
-	dispose(): void {
+	override dispose(): void {
 		if (this.disposable) {
 			this.disposable.dispose();
 		}

extensions/mssql/src/objectExplorerNodeProvider/hdfsCommands.ts

@@ -62,7 +62,7 @@ export class UploadFilesCommand extends ProgressCommand {
 		super('mssqlCluster.uploadFiles', prompter, appContext);
 	}
 
-	protected async preExecute(context: ICommandViewContext | ICommandObjectExplorerContext, args: object = {}): Promise<any> {
+	protected override async preExecute(context: ICommandViewContext | ICommandObjectExplorerContext, args: object = {}): Promise<any> {
 		return this.execute(context, args);
 	}
 
@@ -138,7 +138,7 @@ export class MkDirCommand extends ProgressCommand {
 		super('mssqlCluster.mkdir', prompter, appContext);
 	}
 
-	protected async preExecute(context: ICommandViewContext | ICommandObjectExplorerContext, args: object = {}): Promise<any> {
+	protected override async preExecute(context: ICommandViewContext | ICommandObjectExplorerContext, args: object = {}): Promise<any> {
 		return this.execute(context, args);
 	}
 
@@ -185,7 +185,7 @@ export class DeleteFilesCommand extends Command {
 		super('mssqlCluster.deleteFiles', appContext);
 	}
 
-	protected async preExecute(context: ICommandViewContext | ICommandObjectExplorerContext, args: object = {}): Promise<any> {
+	protected override async preExecute(context: ICommandViewContext | ICommandObjectExplorerContext, args: object = {}): Promise<any> {
 		return this.execute(context, args);
 	}
 
@@ -257,7 +257,7 @@ export class SaveFileCommand extends ProgressCommand {
 		super('mssqlCluster.saveFile', prompter, appContext);
 	}
 
-	protected async preExecute(context: ICommandViewContext | ICommandObjectExplorerContext, args: object = {}): Promise<any> {
+	protected override async preExecute(context: ICommandViewContext | ICommandObjectExplorerContext, args: object = {}): Promise<any> {
 		return this.execute(context, args);
 	}
 
@@ -297,7 +297,7 @@ export class PreviewFileCommand extends ProgressCommand {
 		super('mssqlCluster.previewFile', prompter, appContext);
 	}
 
-	protected async preExecute(context: ICommandViewContext | ICommandObjectExplorerContext, args: object = {}): Promise<any> {
+	protected override async preExecute(context: ICommandViewContext | ICommandObjectExplorerContext, args: object = {}): Promise<any> {
 		return this.execute(context, args);
 	}
 
@@ -376,7 +376,7 @@ export class CopyPathCommand extends Command {
 		super('mssqlCluster.copyPath', appContext);
 	}
 
-	protected async preExecute(context: ICommandViewContext | ICommandObjectExplorerContext, args: object = {}): Promise<any> {
+	protected override async preExecute(context: ICommandViewContext | ICommandObjectExplorerContext, args: object = {}): Promise<any> {
 		return this.execute(context, args);
 	}
 

extensions/mssql/src/objectExplorerNodeProvider/hdfsProvider.ts

@@ -188,21 +188,21 @@ export class ConnectionNode extends FolderNode {
 		super(context, '/', undefined, Constants.MssqlClusterItems.Connection);
 	}
 
-	getDisplayName(): string {
+	override getDisplayName(): string {
 		return this.displayName;
 	}
 
-	public async delete(): Promise<void> {
+	public override async delete(): Promise<void> {
 		throw new Error(localize('errDeleteConnectionNode', "Cannot delete a connection. Only subfolders and files can be deleted."));
 	}
 
-	async getTreeItem(): Promise<vscode.TreeItem> {
+	override async getTreeItem(): Promise<vscode.TreeItem> {
 		let item = await super.getTreeItem();
 		item.contextValue = this._nodeType;
 		return item;
 	}
 
-	public async getFileSource(): Promise<IFileSource | undefined> {
+	public override async getFileSource(): Promise<IFileSource | undefined> {
 		// The node is initially created without a filesource and then one is created only once an action is
 		// taken that requires a connection
 		const fileSource = await super.getFileSource();
@@ -212,7 +212,7 @@ export class ConnectionNode extends FolderNode {
 		return super.getFileSource();
 	}
 
-	getNodeInfo(): azdata.NodeInfo {
+	override getNodeInfo(): azdata.NodeInfo {
 		// TODO handle error message case by returning it in the OE API
 		// TODO support better mapping of node type
 		let nodeInfo: azdata.NodeInfo = {