mirror of
https://github.com/ckaczor/azuredatastudio.git
synced 2026-01-24 17:23:05 -05:00
Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898 (#15681)
* Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898 * Fixes and cleanup * Distro * Fix hygiene yarn * delete no yarn lock changes file * Fix hygiene * Fix layer check * Fix CI * Skip lib checks * Remove tests deleted in vs code * Fix tests * Distro * Fix tests and add removed extension point * Skip failing notebook tests for now * Disable broken tests and cleanup build folder * Update yarn.lock and fix smoke tests * Bump sqlite * fix contributed actions and file spacing * Fix user data path * Update yarn.locks Co-authored-by: ADS Merger <karlb@microsoft.com>
This commit is contained in:
@@ -125,7 +125,7 @@ export class SelectBox extends vsSelectBox {
|
||||
}
|
||||
}
|
||||
|
||||
public get onDidSelect(): Event<ISelectData> {
|
||||
public override get onDidSelect(): Event<ISelectData> {
|
||||
// We override the onDidSelect event here because the base onDidSelect event isn't fired when
|
||||
// selecting an element via select - which means that we'll miss out on a selection made that way.
|
||||
// So we expose our own event that's fired either when the base onDidSelect is called or when we
|
||||
@@ -165,7 +165,7 @@ export class SelectBox extends vsSelectBox {
|
||||
this._dialogOptions = options;
|
||||
}
|
||||
|
||||
public style(styles: ISelectBoxStyles): void {
|
||||
public override style(styles: ISelectBoxStyles): void {
|
||||
super.style(styles);
|
||||
this.enabledSelectBackground = this.selectBackground;
|
||||
this.enabledSelectForeground = this.selectForeground;
|
||||
@@ -196,7 +196,7 @@ export class SelectBox extends vsSelectBox {
|
||||
}
|
||||
}
|
||||
|
||||
public select(index: number): void {
|
||||
public override select(index: number): void {
|
||||
super.select(index);
|
||||
let selectedOptionIndex = this._optionsDictionary.get(this._selectedOption);
|
||||
if (selectedOptionIndex === index) { // Not generating an event if the same value is selected.
|
||||
@@ -212,7 +212,7 @@ export class SelectBox extends vsSelectBox {
|
||||
}
|
||||
|
||||
|
||||
public setOptions(options: string[] | SelectOptionItemSQL[] | ISelectOptionItem[], selected?: number): void {
|
||||
public override setOptions(options: string[] | SelectOptionItemSQL[] | ISelectOptionItem[], selected?: number): void {
|
||||
let selectOptions: SelectOptionItemSQL[] = SelectBox.createOptions(options);
|
||||
this.populateOptionsDictionary(selectOptions);
|
||||
super.setOptions(selectOptions, selected);
|
||||
@@ -350,7 +350,7 @@ export class SelectBox extends vsSelectBox {
|
||||
}
|
||||
}
|
||||
|
||||
public render(container: HTMLElement): void {
|
||||
public override render(container: HTMLElement): void {
|
||||
let selectOptions: ISelectBoxOptionsWithLabel = this._selectBoxOptions as ISelectBoxOptionsWithLabel;
|
||||
|
||||
if (selectOptions && selectOptions.labelText && selectOptions.labelText !== undefined) {
|
||||
|
||||
Reference in New Issue
Block a user