Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898 (#15681)

* Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898

* Fixes and cleanup

* Distro

* Fix hygiene yarn

* delete no yarn lock changes file

* Fix hygiene

* Fix layer check

* Fix CI

* Skip lib checks

* Remove tests deleted in vs code

* Fix tests

* Distro

* Fix tests and add removed extension point

* Skip failing notebook tests for now

* Disable broken tests and cleanup build folder

* Update yarn.lock and fix smoke tests

* Bump sqlite

* fix contributed actions and file spacing

* Fix user data path

* Update yarn.locks

Co-authored-by: ADS Merger <karlb@microsoft.com>

src/sql/workbench/browser/editor/profiler/dashboardInput.ts

@@ -68,7 +68,7 @@ export class DashboardInput extends EditorInput {
 		this._uniqueSelector = uniqueSelector;
 	}
 
-	public getTypeId(): string {
+	override get typeId(): string {
 		return DashboardInput.ID;
 	}
 
@@ -79,7 +79,7 @@ export class DashboardInput extends EditorInput {
 		});
 	}
 
-	public getName(): string {
+	public override getName(): string {
 		if (!this.connectionProfile) {
 			return '';
 		}
@@ -102,7 +102,7 @@ export class DashboardInput extends EditorInput {
 		return this._uri;
 	}
 
-	public dispose(): void {
+	public override dispose(): void {
 		this._disposeContainer();
 		if (this._onConnectionChanged) {
 			this._onConnectionChanged.dispose();
@@ -147,7 +147,7 @@ export class DashboardInput extends EditorInput {
 		return this._uniqueSelector;
 	}
 
-	public matches(otherinput: any): boolean {
+	public override matches(otherinput: any): boolean {
 		return otherinput instanceof DashboardInput
 			&& DashboardInput.profileMatches(this.connectionProfile, otherinput.connectionProfile);
 	}

src/sql/workbench/browser/editor/profiler/profilerInput.ts

@@ -117,11 +117,11 @@ export class ProfilerInput extends EditorInput implements IProfilerSession {
 		return this._sessionName;
 	}
 
-	public getTypeId(): string {
+	override get typeId(): string {
 		return ProfilerInput.ID;
 	}
 
-	public getName(): string {
+	public override getName(): string {
 		let name: string = nls.localize('profilerInput.profiler', "Profiler");
 		if (!this.connection) {
 			return name;
@@ -277,7 +277,7 @@ export class ProfilerInput extends EditorInput implements IProfilerSession {
 		this.data.clearFilter();
 	}
 
-	dispose() {
+	override dispose() {
 		super.dispose();
 		this._profilerService.disconnectSession(this.id);
 	}

src/sql/workbench/browser/editor/resourceViewer/resourceViewerInput.ts

@@ -49,11 +49,11 @@ export class ResourceViewerInput extends EditorInput {
 		this.refresh().catch(err => onUnexpectedError(err));
 	}
 
-	public getTypeId(): string {
+	override get typeId(): string {
 		return ResourceViewerInput.ID;
 	}
 
-	public getName(): string {
+	public override getName(): string {
 		return this._dataGridProvider.title || nls.localize('resourceViewerInput.resourceViewer', "Resource Viewer");
 	}
 
@@ -70,7 +70,7 @@ export class ResourceViewerInput extends EditorInput {
 		return this._columns;
 	}
 
-	isDirty(): boolean {
+	override isDirty(): boolean {
 		return false;
 	}