Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898 (#15681)

* Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898

* Fixes and cleanup

* Distro

* Fix hygiene yarn

* delete no yarn lock changes file

* Fix hygiene

* Fix layer check

* Fix CI

* Skip lib checks

* Remove tests deleted in vs code

* Fix tests

* Distro

* Fix tests and add removed extension point

* Skip failing notebook tests for now

* Disable broken tests and cleanup build folder

* Update yarn.lock and fix smoke tests

* Bump sqlite

* fix contributed actions and file spacing

* Fix user data path

* Update yarn.locks

Co-authored-by: ADS Merger <karlb@microsoft.com>
This commit is contained in:
Charles Gagnon
2021-06-17 08:17:11 -07:00
committed by GitHub
parent fdcb97c7f7
commit 3cb2f552a6
2582 changed files with 124827 additions and 87099 deletions

View File

@@ -52,7 +52,7 @@ export class EditCellAction extends ToggleableAction {
this.toggle(value);
}
public async run(context: CellContext): Promise<void> {
public override async run(context: CellContext): Promise<void> {
this.editMode = !this.editMode;
context.cell.isEditMode = this.editMode;
}
@@ -236,7 +236,7 @@ export class ClearCellOutputAction extends CellActionBase {
super(id, label, undefined, notificationService);
}
public canRun(context: CellContext): boolean {
public override canRun(context: CellContext): boolean {
return context.cell && context.cell.cellType === CellTypes.Code;
}
@@ -270,7 +270,7 @@ export class RunCellsAction extends CellActionBase {
super(id, label, undefined, notificationService);
}
public canRun(context: CellContext): boolean {
public override canRun(context: CellContext): boolean {
return context.cell && context.cell.cellType === CellTypes.Code;
}
@@ -307,7 +307,7 @@ export class CollapseCellAction extends CellActionBase {
super(id, label, undefined, notificationService);
}
public canRun(context: CellContext): boolean {
public override canRun(context: CellContext): boolean {
return context.cell && context.cell.cellType === CellTypes.Code;
}
@@ -350,7 +350,7 @@ export class ToggleMoreActions extends Action {
super(ToggleMoreActions.ID, ToggleMoreActions.LABEL, ToggleMoreActions.ICON);
}
async run(context: StandardKeyboardEvent): Promise<void> {
override async run(context: StandardKeyboardEvent): Promise<void> {
this._contextMenuService.showContextMenu({
getAnchor: () => context.target,
getActions: () => this._actions,
@@ -368,7 +368,7 @@ export class ParametersCellAction extends CellActionBase {
super(id, label, undefined, notificationService);
}
public canRun(context: CellContext): boolean {
public override canRun(context: CellContext): boolean {
return context.cell?.cellType === CellTypes.Code;
}