ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Correctly set focus on new Notebook cells after clicking on inline buttons. (#6708)

Browse Source
This commit is contained in:
Cory Rivera
2019-08-13 14:14:18 -07:00
committed by Charles Gagnon
parent 1a5469b7a1
commit 3cc849a999
2 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/sql/workbench/parts/notebook/browser/notebook.component.html
View File

@@ -11,11 +11,11 @@
<loading-spinner [loading]="isLoading"></loading-spinner> <loading-spinner [loading]="isLoading"></loading-spinner>
<div class="hoverButtonsContainer" *ngIf="(cells && cells.length > 0) && !isLoading"> <div class="hoverButtonsContainer" *ngIf="(cells && cells.length > 0) && !isLoading">
<span class="containerBackground"></span> <span class="containerBackground"></span>
<button class="hoverButton" (click)="addCell('code', 0)"> <button class="hoverButton" (click)="addCell('code', 0, $event)">
<div class="addCodeIcon"></div> <div class="addCodeIcon"></div>
<span>{{addCodeLabel}}</span> <span>{{addCodeLabel}}</span>
</button> </button>
<button class="hoverButton" (click)="addCell('markdown', 0)"> <button class="hoverButton" (click)="addCell('markdown', 0, $event)">
<div class="addTextIcon"></div> <div class="addTextIcon"></div>
<span>{{addTextLabel}}</span> <span>{{addTextLabel}}</span>
</button> </button>
@@ -29,11 +29,11 @@
</div> </div>
<div class="hoverButtonsContainer"> <div class="hoverButtonsContainer">
<span class="containerBackground"></span> <span class="containerBackground"></span>
<button class="hoverButton" (click)="addCell('code', findCellIndex(cell) + 1)"> <button class="hoverButton" (click)="addCell('code', findCellIndex(cell) + 1, $event)">
<div class="addCodeIcon"></div> <div class="addCodeIcon"></div>
<span>{{addCodeLabel}}</span> <span>{{addCodeLabel}}</span>
</button> </button>
<button class="hoverButton" (click)="addCell('markdown', findCellIndex(cell) + 1)"> <button class="hoverButton" (click)="addCell('markdown', findCellIndex(cell) + 1, $event)">
<div class="addTextIcon"></div> <div class="addTextIcon"></div>
<span>{{addTextLabel}}</span> <span>{{addTextLabel}}</span>
</button> </button>

5
src/sql/workbench/parts/notebook/browser/notebook.component.ts
View File

@@ -200,7 +200,10 @@ export class NotebookComponent extends AngularDisposable implements OnInit, OnDe
} }
// Add cell based on cell type // Add cell based on cell type
public addCell(cellType: CellType, index?: number) { public addCell(cellType: CellType, index?: number, event?: Event) {
if (event) {
event.stopPropagation();
}
this._model.addCell(cellType, index); this._model.addCell(cellType, index);
} }