From 3d81da97624d25f12965e5770a1e91eefb41a09b Mon Sep 17 00:00:00 2001 From: Kartik Arora <33497301+ktech99@users.noreply.github.com> Date: Fri, 11 Sep 2020 14:42:13 -0700 Subject: [PATCH] fix bug that doesn't register double click enabled on new notebook contexts (#12239) --- .../contrib/notebook/browser/cellViews/textCell.component.ts | 1 + src/sql/workbench/contrib/notebook/browser/notebook.component.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/src/sql/workbench/contrib/notebook/browser/cellViews/textCell.component.ts b/src/sql/workbench/contrib/notebook/browser/cellViews/textCell.component.ts index d98858bbb0..8568b2d169 100644 --- a/src/sql/workbench/contrib/notebook/browser/cellViews/textCell.component.ts +++ b/src/sql/workbench/contrib/notebook/browser/cellViews/textCell.component.ts @@ -107,6 +107,7 @@ export class TextCellComponent extends CellView implements OnInit, OnChanges { super(); this.setTurndownOptions(); this.markdownRenderer = this._instantiationService.createInstance(NotebookMarkdownRenderer); + this.doubleClickEditEnabled = this._configurationService.getValue('notebook.enableDoubleClickEdit'); this._register(toDisposable(() => { if (this.markdownResult) { this.markdownResult.dispose(); diff --git a/src/sql/workbench/contrib/notebook/browser/notebook.component.ts b/src/sql/workbench/contrib/notebook/browser/notebook.component.ts index d1c7929b40..64b2f96dea 100644 --- a/src/sql/workbench/contrib/notebook/browser/notebook.component.ts +++ b/src/sql/workbench/contrib/notebook/browser/notebook.component.ts @@ -113,6 +113,7 @@ export class NotebookComponent extends AngularDisposable implements OnInit, OnDe super(); this.updateProfile(); this.isLoading = true; + this.doubleClickEditEnabled = this._configurationService.getValue('notebook.enableDoubleClickEdit'); this._register(this._configurationService.onDidChangeConfiguration(e => { this.previewFeaturesEnabled = this._configurationService.getValue('workbench.enablePreviewFeatures'); }));