From 4095037f2578c23033867e611e82c13de114ca5a Mon Sep 17 00:00:00 2001 From: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com> Date: Wed, 10 Jun 2020 22:56:57 -0700 Subject: [PATCH] Fix Notebook Viewlet Highlighting (#10868) (#10870) * Stop double tree data provider registrations * revert book finding logic, leverage currentBook --- extensions/notebook/src/book/bookTreeView.ts | 6 ++---- extensions/notebook/src/extension.ts | 2 -- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/extensions/notebook/src/book/bookTreeView.ts b/extensions/notebook/src/book/bookTreeView.ts index 083ddbf01d..6a34c66dac 100644 --- a/extensions/notebook/src/book/bookTreeView.ts +++ b/extensions/notebook/src/book/bookTreeView.ts @@ -232,12 +232,10 @@ export class BookTreeViewProvider implements vscode.TreeDataProvider openDocument.document.uri.fsPath.replace(/\\/g, '/').toLowerCase().indexOf(b.bookPath.toLowerCase()) > -1); - bookItem = book?.getNotebook(openDocument.document.uri.fsPath); + bookItem = this.currentBook?.getNotebook(openDocument.document.uri.fsPath); } } else if (uri.fsPath) { - let book = this.books.find(b => uri.fsPath.replace(/\\/g, '/').toLowerCase().indexOf(b.bookPath.toLowerCase()) > -1); - bookItem = book?.getNotebook(uri.fsPath); + bookItem = this.currentBook?.getNotebook(uri.fsPath); } if (bookItem) { // Select + focus item in viewlet if books viewlet is already open, or if we pass in variable diff --git a/extensions/notebook/src/extension.ts b/extensions/notebook/src/extension.ts index 5f16ab543d..69fad3a42b 100644 --- a/extensions/notebook/src/extension.ts +++ b/extensions/notebook/src/extension.ts @@ -138,8 +138,6 @@ export async function activate(extensionContext: vscode.ExtensionContext): Promi }); - extensionContext.subscriptions.push(vscode.window.registerTreeDataProvider(BOOKS_VIEWID, bookTreeViewProvider)); - extensionContext.subscriptions.push(vscode.window.registerTreeDataProvider(PROVIDED_BOOKS_VIEWID, providedBookTreeViewProvider)); return { getJupyterController() { return controller;