mirror of
https://github.com/ckaczor/azuredatastudio.git
synced 2026-03-17 19:11:36 -04:00
Enabling FILEGROUPS tab experience to the database properties (#24226)
* initial changes for loadin dsc table with real values from smo * Displaying diff columns for DSC for diff sql server * checkbox maiants the selection * elevate option fails to load correct value when set to when_supported option * all working till maxdop, todo pause option, save * commented MAXDOP changes, as it is causing issues * primary,sec,checkbox working as expected, TODO:MaxDop etc options,saving,tests * Undo MAXDOP commented code * refactored with service data * column header width adjustments * Maxdop and pause resume options completed, apply button is failing now * Removed option names from loc and using Id instead as names may change in future like in doc * Apply button fixed * refactored to reduce table reload * Ledger digest completed * refactor done: maxdop secondary shows wrong data from pause_resume * refactor more: all working but table focus disturbs on update table * adds conditions for unsupported dsc to <2016 server * maxdop secondary checkbox fix * rows still loses focus after value change due to update table row data * Fixed updating secondary dropdown value * reusing the private method and removed the duplicated codes * initial commit - fullText and owner need revision * Enter key in input type allows the change to update the table data, reduces the live update issues * Setting focus to the current row * loading data, need stylings-increase col length, etc * using the existed setTableData method * Adding new file dialog * creating addFile, but not displaying in table, issue with appendData * Adding row to the table, options are getting from STS * all working except InPercent value * code review comment updates * Input type checkbox update table additional validation * all except path * fixing the input type focus and reverting the enterKeyPress logic * browse path is created, need stylings,refactor,filestream selection and add * fixing the flickering issue with data refresh * new file options toggle and grid display string updates * moving code inline and using actual component * cleanup * Add file saving is done, except one styling issue with autogrowth section * add,remove working, need to edit file * add, edit, remove - all working, need css fixes and -1 fix * addressing code review comments * adding local changes adn fixing for edit file * adjusting css * addressing code review comment for using loc var instead of duplicated line of code to get the rowinfo * all fixed, need testing and refactor * vBump STS and fixing required field causing the apply button not enable for other options on main branch * fixing autogrowth radio buttons change updates * all working except some css * disabled size for filestream * fixing filegroups and filetypes scnearios, added filename validation for newfile, todo:editingNew file * added max and min values to the inputs * editing filename validation completed, all done exccept CSS * all fixed except scroll bar * edit db file header, filename enable issue fix * PR comment supporting updates for STS * initial commit * min updates * loading data into table.. adding rows * modfying addButtonsForTable method and reusing it for edit button * add empty row/remove done, edit name and other columns required and save with tests * All working except new name validation * adding validation * code review comment updates * Dialogbase addbuttons to table refactored * more typo fixes * all working except 'Remove' revist logic and delete correct row * removing fulltext index prop * adding defualt conditions to the columns checkboxes * service fix * using path.join instead of hardcoded separators * updating files is updating filegroups tabs, removing fg to file update required * fixed toggle remove button for tab;es * filegroup refactor * update filegroups and files on new fg name * final commit changes * code review updates * vBump STS to 4.9.0.26
This commit is contained in:
committed by
GitHub
parent
e4abe4d167
commit
41202a65bd
@@ -77,7 +77,7 @@ export abstract class DialogBase<DialogResult> {
|
||||
|
||||
protected onFormFieldChange(): void { }
|
||||
|
||||
protected get removeButtonEnabled(): boolean { return true; }
|
||||
protected removeButtonEnabled(table: azdata.TableComponent): boolean { return true; }
|
||||
|
||||
protected validateInput(): Promise<string[]> { return Promise.resolve([]); }
|
||||
|
||||
@@ -244,7 +244,7 @@ export abstract class DialogBase<DialogResult> {
|
||||
return table;
|
||||
}
|
||||
|
||||
protected async setTableData(table: azdata.TableComponent, data: any[][], maxRowCount: number = DefaultMaxTableRowCount) {
|
||||
protected async setTableData(table: azdata.TableComponent, data: any[][], maxRowCount: number = DefaultMaxTableRowCount): Promise<void> {
|
||||
await table.updateProperties({
|
||||
data: data,
|
||||
height: getTableHeight(data.length, DefaultMinTableRowCount, maxRowCount)
|
||||
@@ -314,7 +314,7 @@ export abstract class DialogBase<DialogResult> {
|
||||
buttonComponents.push(removeButtonComponent);
|
||||
|
||||
this.disposables.push(table.onRowSelected(() => {
|
||||
const isRemoveButtonEnabled = this.removeButtonEnabled;
|
||||
const isRemoveButtonEnabled = this.removeButtonEnabled(table);
|
||||
updateButtons(isRemoveButtonEnabled);
|
||||
}));
|
||||
|
||||
|
||||
Reference in New Issue
Block a user