ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-02 09:35:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix GetConnection (#19579)

Browse Source
This commit is contained in:
Charles Gagnon
2022-05-31 21:32:44 -07:00
committed by GitHub
parent eb2cd6238f
commit 41a3c8661c
6 changed files with 27 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/sql/workbench/services/connection/browser/connectionManagementService.ts
View File

@@ -1634,20 +1634,6 @@ export class ConnectionManagementService extends Disposable implements IConnecti
return connections;
}
public getConnection(uri: string): ConnectionProfile {
const connections = this.getActiveConnections();
if (connections) {
for (let connection of connections) {
let connectionUri = this.getConnectionUriFromId(connection.id);
if (connectionUri === uri) {
return connection;
}
}
}
return undefined;
}
private getConnectionsInGroup(group: ConnectionProfileGroup): ConnectionProfile[] {
const connections = [];
if (group) {

4
src/sql/workbench/services/connection/test/browser/connectionManagementService.test.ts
View File

@@ -781,8 +781,8 @@ suite('SQL ConnectionManagementService tests', () => {
await connect(uri, options, true, profile);
// invalid uri check.
assert.strictEqual(connectionManagementService.getConnection(badString), undefined);
let returnedProfile = connectionManagementService.getConnection(uri);
assert.strictEqual(connectionManagementService.getConnectionProfile(badString), undefined);
let returnedProfile = connectionManagementService.getConnectionProfile(uri);
assert.strictEqual(returnedProfile.groupFullName, profile.groupFullName);
assert.strictEqual(returnedProfile.groupId, profile.groupId);
});