From 41e6f3b84b9c5fb2a063d56df367e160f006d533 Mon Sep 17 00:00:00 2001 From: Kim Santiago <31145923+kisantia@users.noreply.github.com> Date: Fri, 21 Apr 2023 09:53:02 -0700 Subject: [PATCH] fix accessibility issue for open dialog location radio button (#22812) * fix accessibliity issue where location radio button showed as required * fix ariaLabel --- extensions/data-workspace/src/common/constants.ts | 1 + .../data-workspace/src/dialogs/openExistingDialog.ts | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/extensions/data-workspace/src/common/constants.ts b/extensions/data-workspace/src/common/constants.ts index a74be5a0c7..8cf91d209a 100644 --- a/extensions/data-workspace/src/common/constants.ts +++ b/extensions/data-workspace/src/common/constants.ts @@ -85,6 +85,7 @@ export const GitRepoUrlTitle = localize('dataworkspace.gitRepoUrlTitle', "Git re export const GitRepoUrlPlaceholder = localize('dataworkspace.gitRepoUrlPlaceholder', "Enter remote git repository URL"); export const LocalClonePathTitle = localize('dataworkspace.localClonePathTitle', "Local clone path"); export const LocalClonePathPlaceholder = localize('dataworkspace.localClonePathPlaceholder', "Select location to clone repository locally"); +export const ProjectFileTitle = localize('dataworkspace.projectFileTitle', "Project file"); // Workspace settings for saving new projects export const ProjectConfigurationKey = 'projects'; diff --git a/extensions/data-workspace/src/dialogs/openExistingDialog.ts b/extensions/data-workspace/src/dialogs/openExistingDialog.ts index 36605bf5b1..28f0bdb1d8 100644 --- a/extensions/data-workspace/src/dialogs/openExistingDialog.ts +++ b/extensions/data-workspace/src/dialogs/openExistingDialog.ts @@ -119,7 +119,6 @@ export class OpenExistingDialog extends DialogBase { this.locationRadioButtonFormComponent = { title: constants.LocationSelectorTitle, - required: true, component: view.modelBuilder.flexContainer() .withItems([this.localRadioButton, this.remoteGitRepoRadioButton], { flex: '0 0 auto', CSSStyles: { 'margin-right': '15px' } }) .withProps({ ariaRole: 'radiogroup' }) @@ -192,7 +191,7 @@ export class OpenExistingDialog extends DialogBase { }; this.filePathTextBox = view.modelBuilder.inputBox().withProps({ - ariaLabel: constants.LocationSelectorTitle, + ariaLabel: constants.ProjectFileTitle, placeHolder: constants.ProjectFilePlaceholder, required: true, width: constants.DefaultInputWidth @@ -212,9 +211,10 @@ export class OpenExistingDialog extends DialogBase { this.register(localProjectBrowseFolderButton.onDidClick(() => this.onBrowseButtonClick())); const flexContainer = this.createHorizontalContainer(view, [this.filePathTextBox, localProjectBrowseFolderButton]); - void flexContainer.updateCssStyles({ 'margin-top': '-10px' }); this.filePathAndButtonComponent = { - component: flexContainer + component: flexContainer, + title: constants.ProjectFileTitle, + required: true }; this.formBuilder = view.modelBuilder.formContainer().withFormItems([