fix error message formatting (#2477)

This commit is contained in:
Anthony Dresser
2018-09-10 14:58:51 -07:00
committed by Karl Burtram
parent 8444271c58
commit 432a209184
2 changed files with 16 additions and 4 deletions

View File

@@ -19,7 +19,8 @@
} }
.message-tree .message, .message-tree .message,
.message-tree .batch-start { .message-tree .batch-start,
.message-tree .error-message {
display: inline-block; display: inline-block;
} }
@@ -27,6 +28,10 @@
text-decoration: underline; text-decoration: underline;
} }
.message-tree .error-message {
color: red;
}
.message-tree .batch-start:hover { .message-tree .batch-start:hover {
color: red; color: red;
} }

View File

@@ -56,7 +56,8 @@ interface IBatchTemplate extends IMessageTemplate {
const TemplateIds = { const TemplateIds = {
MESSAGE: 'message', MESSAGE: 'message',
BATCH: 'batch', BATCH: 'batch',
MODEL: 'model' MODEL: 'model',
ERROR: 'error'
}; };
export class MessagePanel extends ViewletPanel { export class MessagePanel extends ViewletPanel {
@@ -176,6 +177,8 @@ class MessageRenderer implements IRenderer {
return TemplateIds.MODEL; return TemplateIds.MODEL;
} else if (element.selection) { } else if (element.selection) {
return TemplateIds.BATCH; return TemplateIds.BATCH;
} else if (element.isError) {
return TemplateIds.ERROR;
} else { } else {
return TemplateIds.MESSAGE; return TemplateIds.MESSAGE;
} }
@@ -191,15 +194,19 @@ class MessageRenderer implements IRenderer {
const timeStamp = $('div.time-stamp').appendTo(container).getHTMLElement(); const timeStamp = $('div.time-stamp').appendTo(container).getHTMLElement();
const message = $('div.batch-start').appendTo(container).getHTMLElement(); const message = $('div.batch-start').appendTo(container).getHTMLElement();
return { message, timeStamp }; return { message, timeStamp };
} else if (templateId === TemplateIds.ERROR) {
$('div.time-stamp').appendTo(container);
const message = $('div.error-message').appendTo(container).getHTMLElement();
return { message };
} else { } else {
return undefined; return undefined;
} }
} }
renderElement(tree: ITree, element: IResultMessage, templateId: string, templateData: IMessageTemplate | IBatchTemplate): void { renderElement(tree: ITree, element: IResultMessage, templateId: string, templateData: IMessageTemplate | IBatchTemplate): void {
if (templateId === TemplateIds.MESSAGE) { if (templateId === TemplateIds.MESSAGE || templateId === TemplateIds.ERROR) {
let data: IMessageTemplate = templateData; let data: IMessageTemplate = templateData;
data.message.innerText = element.message; data.message.innerText = element.message.replace(/(\r\n|\n|\r)/g, ' ');
} else if (templateId === TemplateIds.BATCH) { } else if (templateId === TemplateIds.BATCH) {
let data = templateData as IBatchTemplate; let data = templateData as IBatchTemplate;
data.timeStamp.innerText = element.time; data.timeStamp.innerText = element.time;