ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Check provider type before throwing error message on cloud servers (#5948)

Browse Source 
* check provider type in backup action

* check provider name in case of restore as well

* removed harcoding of constant
This commit is contained in:
Anup N. Kamath
2019-06-19 22:53:54 -07:00
committed by Alan Ren
parent b9a0c9ce7e
commit 433e5633cf
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/sql/workbench/common/actions.ts
View File

@@ -26,6 +26,7 @@ import { IEditorService } from 'vs/workbench/services/editor/common/editorServic
import { ServicesAccessor } from 'vs/platform/instantiation/common/instantiation'; import { ServicesAccessor } from 'vs/platform/instantiation/common/instantiation';
import { INotificationService } from 'vs/platform/notification/common/notification'; import { INotificationService } from 'vs/platform/notification/common/notification';
import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
import { mssqlProviderName } from 'sql/platform/connection/common/constants';
export interface BaseActionContext { export interface BaseActionContext {
object?: ObjectMetadata; object?: ObjectMetadata;
@@ -253,7 +254,7 @@ export class BackupAction extends Task {
} }
if (profile) { if (profile) {
const serverInfo = connectionManagementService.getServerInfo(profile.id); const serverInfo = connectionManagementService.getServerInfo(profile.id);
if (serverInfo && serverInfo.isCloud) { if (serverInfo && serverInfo.isCloud && profile.providerName === mssqlProviderName) {
return accessor.get<INotificationService>(INotificationService).info(nls.localize('backup.commandNotSupported', 'Backup command is not supported for Azure SQL databases.')); return accessor.get<INotificationService>(INotificationService).info(nls.localize('backup.commandNotSupported', 'Backup command is not supported for Azure SQL databases.'));
} }
} }
@@ -296,7 +297,7 @@ export class RestoreAction extends Task {
} }
if (profile) { if (profile) {
const serverInfo = connectionManagementService.getServerInfo(profile.id); const serverInfo = connectionManagementService.getServerInfo(profile.id);
if (serverInfo && serverInfo.isCloud) { if (serverInfo && serverInfo.isCloud && profile.providerName === mssqlProviderName) {
return accessor.get<INotificationService>(INotificationService).info(nls.localize('restore.commandNotSupported', 'Restore command is not supported for Azure SQL databases.')); return accessor.get<INotificationService>(INotificationService).info(nls.localize('restore.commandNotSupported', 'Restore command is not supported for Azure SQL databases.'));
} }
} }