mirror of
https://github.com/ckaczor/azuredatastudio.git
synced 2026-01-22 09:35:37 -05:00
Add more Notebook telemetry events (#14755)
* initial checkin * telemetry for search in notebooks * telemetry for move notebook * address comments * feedback changes * fix tests paasing NullAdsTelemetryService * move changeKernel telemetry higher up * remove telemetry service * Fix new Notebook events (#14982) * Notebook telemetry fixes * update2 * Move event location * remove service * remove unused Co-authored-by: chgagnon <chgagnon@microsoft.com>
This commit is contained in:
@@ -20,6 +20,6 @@ export class ModelFactory implements IModelFactory {
|
||||
}
|
||||
|
||||
public createClientSession(options: IClientSessionOptions): IClientSession {
|
||||
return new ClientSession(options);
|
||||
return this.instantiationService.createInstance(ClientSession, options);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -971,6 +971,12 @@ export class NotebookModel extends Disposable implements INotebookModel {
|
||||
if (kernel.info) {
|
||||
this.updateLanguageInfo(kernel.info.language_info);
|
||||
}
|
||||
this.adstelemetryService.createActionEvent(TelemetryKeys.TelemetryView.Notebook, TelemetryKeys.NbTelemetryAction.KernelChanged)
|
||||
.withAdditionalProperties({
|
||||
name: kernel.name,
|
||||
alias: kernelAlias || ''
|
||||
})
|
||||
.send();
|
||||
this._kernelChangedEmitter.fire({
|
||||
newValue: kernel,
|
||||
oldValue: undefined,
|
||||
|
||||
Reference in New Issue
Block a user