From 4425b2afd3ce05fdd8bec83ba4e56ab6255f80e4 Mon Sep 17 00:00:00 2001 From: Charles Gagnon Date: Wed, 17 Mar 2021 09:40:47 -0700 Subject: [PATCH] Fix MIAA connection strings page not populating (#14763) --- .../arc/src/ui/dashboards/miaa/miaaConnectionStringsPage.ts | 5 ++--- extensions/arc/src/ui/dashboards/miaa/miaaDashboard.ts | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/extensions/arc/src/ui/dashboards/miaa/miaaConnectionStringsPage.ts b/extensions/arc/src/ui/dashboards/miaa/miaaConnectionStringsPage.ts index c52ecd5b1b..248a1029ae 100644 --- a/extensions/arc/src/ui/dashboards/miaa/miaaConnectionStringsPage.ts +++ b/extensions/arc/src/ui/dashboards/miaa/miaaConnectionStringsPage.ts @@ -8,7 +8,6 @@ import * as loc from '../../../localizedConstants'; import { IconPathHelper, cssStyles } from '../../../constants'; import { KeyValueContainer, KeyValue, InputKeyValue, MultilineInputKeyValue } from '../../components/keyValueContainer'; import { DashboardPage } from '../../components/dashboardPage'; -import { ControllerModel } from '../../../models/controllerModel'; import { MiaaModel } from '../../../models/miaaModel'; import { parseIpAndPort } from '../../../common/utils'; @@ -17,9 +16,9 @@ export class MiaaConnectionStringsPage extends DashboardPage { private _keyValueContainer!: KeyValueContainer; private _connectionStringsMessage!: azdata.TextComponent; - constructor(modelView: azdata.ModelView, private _controllerModel: ControllerModel, private _miaaModel: MiaaModel) { + constructor(modelView: azdata.ModelView, private _miaaModel: MiaaModel) { super(modelView); - this.disposables.push(this._controllerModel.onRegistrationsUpdated(_ => + this.disposables.push(this._miaaModel.onConfigUpdated(_ => this.eventuallyRunOnInitialized(() => this.updateConnectionStrings()))); } diff --git a/extensions/arc/src/ui/dashboards/miaa/miaaDashboard.ts b/extensions/arc/src/ui/dashboards/miaa/miaaDashboard.ts index b2edee930f..16600c8b89 100644 --- a/extensions/arc/src/ui/dashboards/miaa/miaaDashboard.ts +++ b/extensions/arc/src/ui/dashboards/miaa/miaaDashboard.ts @@ -27,7 +27,7 @@ export class MiaaDashboard extends Dashboard { protected async registerTabs(modelView: azdata.ModelView): Promise<(azdata.DashboardTab | azdata.DashboardTabGroup)[]> { const overviewPage = new MiaaDashboardOverviewPage(modelView, this._controllerModel, this._miaaModel); - const connectionStringsPage = new MiaaConnectionStringsPage(modelView, this._controllerModel, this._miaaModel); + const connectionStringsPage = new MiaaConnectionStringsPage(modelView, this._miaaModel); const computeAndStoragePage = new MiaaComputeAndStoragePage(modelView, this._miaaModel); return [ overviewPage.tab,