extensions tslint cleanup/Connection config refactor (#4370)

* various clean ups

* formatting

* remove linting

* formatting

* IConfigurationService is even better

* messing with connection config tests

* update tests

* formatting

* foramtting

* remove unused code

* add more tests

extensions/mssql/src/sparkFeature/dialog/sparkJobSubmission/sparkJobSubmissionService.ts

@@ -42,7 +42,7 @@ export class SparkJobSubmissionService {
 				},
 				// authentication headers
 				headers: {
-					'Authorization': 'Basic ' + new Buffer(submissionArgs.user + ':' + submissionArgs.password).toString('base64')
+					'Authorization': 'Basic ' + Buffer.from(submissionArgs.user + ':' + submissionArgs.password).toString('base64')
 				}
 			};
 
@@ -100,7 +100,7 @@ export class SparkJobSubmissionService {
 				rejectUnauthorized: false,
 				// authentication headers
 				headers: {
-					'Authorization': 'Basic ' + new Buffer(submissionArgs.user + ':' + submissionArgs.password).toString('base64')
+					'Authorization': 'Basic ' + Buffer.from(submissionArgs.user + ':' + submissionArgs.password).toString('base64')
 				}
 			};
 

extensions/mssql/tsconfig.json

@@ -1,19 +1,15 @@
 {
-    "compileOnSave": true,
-    "compilerOptions": {
-        "module": "commonjs",
-        "target": "es6",
+	"extends": "../shared.tsconfig.json",
+	"compilerOptions": {
 		"outDir": "./out",
-		"lib": [
-			"es6", "es2015.promise"
-		],
-        "sourceMap": true,
-        "emitDecoratorMetadata": true,
-        "experimentalDecorators": true,
-        "moduleResolution": "node",
-        "declaration": false
-    },
-    "exclude": [
-        "node_modules"
-    ]
+		"strict": false,
+		"alwaysStrict": false,
+		"noImplicitAny": false,
+		"noImplicitReturns": false,
+		"noUnusedLocals": false,
+		"noUnusedParameters": false
+	},
+	"include": [
+		"src/**/*"
+	]
 }