extensions tslint cleanup/Connection config refactor (#4370)

* various clean ups

* formatting

* remove linting

* formatting

* IConfigurationService is even better

* messing with connection config tests

* update tests

* formatting

* foramtting

* remove unused code

* add more tests

src/sql/platform/connection/test/common/testConfigurationService.ts

@@ -0,0 +1,79 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import { getConfigurationKeys, IConfigurationOverrides, IConfigurationService, getConfigurationValue, isConfigurationOverrides, ConfigurationTarget } from 'vs/platform/configuration/common/configuration';
+
+export class TestConfigurationService implements IConfigurationService {
+	public _serviceBrand: any;
+
+	private configuration = {
+		user: {},
+		workspace: {}
+	};
+
+	public reloadConfiguration<T>(): Promise<T> {
+		return Promise.resolve(this.getValue());
+	}
+
+	public getValue(arg1?: any, arg2?: any): any {
+		let configuration;
+		configuration = configuration ? configuration : this.configuration;
+		if (arg1 && typeof arg1 === 'string') {
+			return getConfigurationValue(configuration, arg1);
+		}
+		return configuration;
+	}
+
+	public updateValue(key: string, value: any, target?: any): Promise<void> {
+		let _target = (target as ConfigurationTarget) === ConfigurationTarget.USER ? 'user' : 'workspace';
+		let keyArray = key.split('.');
+		let targetObject = this.configuration[_target];
+		for (let i = 0; i < keyArray.length; i++) {
+			if (i === keyArray.length - 1) {
+				targetObject[keyArray[i]] = value;
+			} else {
+				if (!targetObject[keyArray[i]]) {
+					targetObject[keyArray[i]] = {};
+				}
+				targetObject = targetObject[keyArray[i]];
+			}
+		}
+		return Promise.resolve(void 0);
+	}
+
+	public onDidChangeConfiguration() {
+		return { dispose() { } };
+	}
+
+	public inspect<T>(key: string, overrides?: IConfigurationOverrides): {
+		default: T,
+		user: T,
+		workspace?: T,
+		workspaceFolder?: T
+		value: T,
+	} {
+
+		return {
+			value: getConfigurationValue<T>(this.configuration.user, key),
+			default: undefined,
+			user: getConfigurationValue<T>(this.configuration.user, key),
+			workspace: getConfigurationValue<T>(this.configuration.workspace, key),
+			workspaceFolder: undefined
+		};
+	}
+
+	public keys() {
+		return {
+			default: getConfigurationKeys(),
+			user: Object.keys(this.configuration),
+			workspace: [],
+			workspaceFolder: []
+		};
+	}
+
+	public getConfigurationData() {
+		return null;
+	}
+}