From 44e9a97f09ffab0714378c15a51cbf1e6b9dd6f5 Mon Sep 17 00:00:00 2001 From: Alan Ren Date: Tue, 14 Aug 2018 17:38:00 -0700 Subject: [PATCH] fix for issue: Results Grid Row Indicator Zero Based #2152 (#2232) --- .../base/browser/ui/table/plugins/rowNumberColumn.plugin.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/sql/base/browser/ui/table/plugins/rowNumberColumn.plugin.ts b/src/sql/base/browser/ui/table/plugins/rowNumberColumn.plugin.ts index 0c585c4433..65d6de4b85 100644 --- a/src/sql/base/browser/ui/table/plugins/rowNumberColumn.plugin.ts +++ b/src/sql/base/browser/ui/table/plugins/rowNumberColumn.plugin.ts @@ -63,7 +63,9 @@ export class RowNumberColumn implements Slick.Plugin { private formatter(row, cell, value, columnDef: Slick.Column, dataContext): string { if (dataContext) { - return `${row}`; + // row is zero-based, we need make it 1 based for display in the result grid + // + return `${row + 1}`; } return null; }