ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 11:01:37 -05:00
Code Issues Packages Projects Releases Wiki Activity

Move books to insiders (#6428)

Browse Source 
* move books to insiders

* move to insiders

* changed context key for nav buttons

* fixed nav buttons

* check product.quality
This commit is contained in:
Lucy Zhang
2019-07-18 16:35:28 -07:00
committed by GitHub
parent fab3c3a7c3
commit 45c13116de
3 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/notebook/package.json
View File

@@ -339,7 +339,7 @@
{ {
"id": "bookTreeView", "id": "bookTreeView",
"name": "Books", "name": "Books",
"when": "bookOpened && isDevelopment" "when": "bookOpened && notebookQuality != stable"
} }
] ]
} }

4
src/sql/workbench/parts/notebook/notebook.component.ts
View File

@@ -53,8 +53,8 @@ import { ITextFileService } from 'vs/workbench/services/textfile/common/textfile
import { LabeledMenuItemActionItem, fillInActions } from 'vs/platform/actions/browser/menuEntryActionViewItem'; import { LabeledMenuItemActionItem, fillInActions } from 'vs/platform/actions/browser/menuEntryActionViewItem';
import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
import { Button } from 'sql/base/browser/ui/button/button'; import { Button } from 'sql/base/browser/ui/button/button';
import { attachButtonStyler } from 'sql/platform/theme/common/styler';
import { isUndefinedOrNull } from 'vs/base/common/types'; import { isUndefinedOrNull } from 'vs/base/common/types';
import product from 'vs/platform/product/node/product';
export const NOTEBOOK_SELECTOR: string = 'notebook-component'; export const NOTEBOOK_SELECTOR: string = 'notebook-component';
@@ -441,7 +441,7 @@ export class NotebookComponent extends AngularDisposable implements OnInit, OnDe
protected initNavSection(): void { protected initNavSection(): void {
this._navProvider = this.notebookService.getNavigationProvider(this._notebookParams.notebookUri); this._navProvider = this.notebookService.getNavigationProvider(this._notebookParams.notebookUri);
if (this.contextKeyService.getContextKeyValue('isDevelopment') && if (product.quality !== 'stable' &&
this.contextKeyService.getContextKeyValue('bookOpened') && this.contextKeyService.getContextKeyValue('bookOpened') &&
this._navProvider) { this._navProvider) {
this._navProvider.getNavigation(this._notebookParams.notebookUri).then(result => { this._navProvider.getNavigation(this._notebookParams.notebookUri).then(result => {

4
src/sql/workbench/services/notebook/common/notebookServiceImpl.ts
View File

@@ -41,6 +41,7 @@ import { Schemas } from 'vs/base/common/network';
import { ILogService } from 'vs/platform/log/common/log'; import { ILogService } from 'vs/platform/log/common/log';
import { toErrorMessage } from 'vs/base/common/errorMessage'; import { toErrorMessage } from 'vs/base/common/errorMessage';
import { NotebookChangeType } from 'sql/workbench/parts/notebook/models/contracts'; import { NotebookChangeType } from 'sql/workbench/parts/notebook/models/contracts';
import product from 'vs/platform/product/node/product';
export interface NotebookProviderProperties { export interface NotebookProviderProperties {
provider: string; provider: string;
@@ -167,6 +168,9 @@ export class NotebookService extends Disposable implements INotebookService {
lifecycleService.onWillShutdown(() => this.shutdown()); lifecycleService.onWillShutdown(() => this.shutdown());
this.hookContextKeyListeners(); this.hookContextKeyListeners();
this.hookNotebookThemesAndConfigListener(); this.hookNotebookThemesAndConfigListener();
// Temporary (issue #6427 will remove): Add a product quality key so we can only show books on Insiders
this._contextKeyService.createKey<string>('notebookQuality', product.quality);
} }
public dispose(): void { public dispose(): void {