From 4772be5dcc91bfdf58430ab8f0d17d203ca644f2 Mon Sep 17 00:00:00 2001 From: Alan Ren Date: Wed, 10 Mar 2021 16:10:42 -0800 Subject: [PATCH] handle query gallery with tags (#14633) (#14636) * handle query gallery with tags * fix typo --- .../extensionManagement/common/extensionGalleryService.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/vs/platform/extensionManagement/common/extensionGalleryService.ts b/src/vs/platform/extensionManagement/common/extensionGalleryService.ts index 8fd2064066..f768c75abd 100644 --- a/src/vs/platform/extensionManagement/common/extensionGalleryService.ts +++ b/src/vs/platform/extensionManagement/common/extensionGalleryService.ts @@ -608,6 +608,11 @@ export class ExtensionGalleryService implements IExtensionGalleryService { }); } } + // ADS doesn't support extension tags, we need to return empty array to avoid breaking some scenarios. e.g. file extension based recommendations. + const tagFilters = query.criteria.filter(x => x.filterType === FilterType.Tag); + if (tagFilters?.length > 0) { + filteredExtensions = []; + } const searchTexts = query.criteria.filter(x => x.filterType === FilterType.SearchText).map(v => v.value ? v.value.toLocaleLowerCase() : undefined); if (searchTexts && searchTexts.length > 0) { searchTexts.forEach(searchText => {