ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Ensure we call Dispose() on NotebookModel when notebook component is destroyed (#3667)

Browse Source
This commit is contained in:
Chris LaFreniere
2019-01-04 12:00:42 -08:00
committed by GitHub
parent 2d52bc2a49
commit 47c4609f23
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/sql/parts/notebook/notebook.component.ts
View File

@@ -126,6 +126,7 @@ export class NotebookComponent extends AngularDisposable implements OnInit, OnDe
} }
ngOnDestroy() { ngOnDestroy() {
this.dispose();
if (this.notebookService) { if (this.notebookService) {
this.notebookService.removeNotebookEditor(this); this.notebookService.removeNotebookEditor(this);
} }
@@ -242,9 +243,8 @@ export class NotebookComponent extends AngularDisposable implements OnInit, OnDe
model.onError((errInfo: INotification) => this.handleModelError(errInfo)); model.onError((errInfo: INotification) => this.handleModelError(errInfo));
await model.requestModelLoad(this._notebookParams.isTrusted); await model.requestModelLoad(this._notebookParams.isTrusted);
model.contentChanged((change) => this.handleContentChanged(change)); model.contentChanged((change) => this.handleContentChanged(change));
this._model = model; this._model = this._register(model);
this.updateToolbarComponents(this._model.trustedMode); this.updateToolbarComponents(this._model.trustedMode);
this._register(model);
this._modelRegisteredDeferred.resolve(this._model); this._modelRegisteredDeferred.resolve(this._model);
model.backgroundStartSession(); model.backgroundStartSession();
// Set first cell as default active cell // Set first cell as default active cell