ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Test fixes based on recent changes (#5570)

Browse Source 
* Test fixes based on recent changes and allowing toolbar to stay at top

* removing scroll changes to be in seperate PR
This commit is contained in:
udeeshagautam
2019-05-21 19:56:44 -07:00
committed by GitHub
parent ab3a64604a
commit 48a6157efb
6 changed files with 21 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
extensions/schema-compare/src/schemaCompareResult.ts
View File

@@ -160,7 +160,6 @@ export class SchemaCompareResult {
await view.initializeModel(this.flexModel);
});
this.editor.openEditor();
}
public start(): void {
@@ -172,7 +171,7 @@ export class SchemaCompareResult {
return this.comparisonResult;
}
private async execute(): Promise<void> {
public async execute(): Promise<void> {
if (this.schemaCompareOptionDialog && this.schemaCompareOptionDialog.deploymentOptions) {
// take updates if any
this.deploymentOptions = this.schemaCompareOptionDialog.deploymentOptions;

17
extensions/schema-compare/src/test/schemaCompare.test.ts
View File

@@ -6,8 +6,6 @@
'use strict';
import * as should from 'should';
import * as TypeMoq from 'typemoq';
import * as vscode from 'vscode';
import * as azdata from 'azdata';
import 'mocha';
import { SchemaCompareDialog } from './../dialogs/schemaCompareDialog';
@@ -51,13 +49,13 @@ const mockTargetEndpoint: azdata.SchemaCompareEndpointInfo = {
};
describe('SchemaCompareDialog.openDialog', function(): void {
it('Should be correct when created.', function(): void {
it('Should be correct when created.', async function(): Promise<void> {
let dialog = new SchemaCompareDialog();
dialog.openDialog(mockConnectionProfile);
await dialog.openDialog(mockConnectionProfile);
should(dialog.dialog.title).equal('Schema Compare');
should(dialog.dialog.okButton.label).equal('Compare');
should(dialog.dialog.okButton.enabled).equal(true);
should(dialog.dialog.okButton.label).equal('Ok');
should(dialog.dialog.okButton.enabled).equal(false); // Should be false when open
});
});
@@ -71,7 +69,10 @@ describe('SchemaCompareResult.start', function(): void {
await promise;
await result.start();
should(result.getComparisionResult().success).equal(true);
should(result.getComparisionResult().operationId).equal(sc.testOperationId);
should(result.getComparisionResult() === undefined);
await result.execute();
should(result.getComparisionResult() !== undefined);
should(result.getComparisionResult().operationId !== undefined);
});
});