ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Update contracts (#21577)

Browse Source
This commit is contained in:
Raymond Truong
2023-01-12 18:23:23 -08:00
committed by GitHub
parent d87a33188c
commit 49c46cee20
4 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
extensions/mssql/src/contracts.ts
View File

@@ -1101,6 +1101,7 @@ export namespace ProfilerSessionCreatedNotification {
export interface SqlMigrationAssessmentParams { export interface SqlMigrationAssessmentParams {
ownerUri: string; ownerUri: string;
databases: string[]; databases: string[];
xEventsFilesFolderPath: string;
} }
export namespace GetSqlMigrationAssessmentItemsRequest { export namespace GetSqlMigrationAssessmentItemsRequest {

6
extensions/mssql/src/mssql.d.ts vendored
View File

@@ -701,7 +701,7 @@ declare module 'mssql' {
} }
export interface ISqlMigrationService { export interface ISqlMigrationService {
getAssessments(ownerUri: string, databases: string[]): Promise<AssessmentResult | undefined>; getAssessments(ownerUri: string, databases: string[], xEventsFilesFolderPath: string): Promise<AssessmentResult | undefined>;
getSkuRecommendations(dataFolder: string, perfQueryIntervalInSec: number, targetPlatforms: string[], targetSqlInstance: string, targetPercentile: number, scalingFactor: number, startTime: string, endTime: string, includePreviewSkus: boolean, databaseAllowList: string[]): Promise<SkuRecommendationResult | undefined>; getSkuRecommendations(dataFolder: string, perfQueryIntervalInSec: number, targetPlatforms: string[], targetSqlInstance: string, targetPercentile: number, scalingFactor: number, startTime: string, endTime: string, includePreviewSkus: boolean, databaseAllowList: string[]): Promise<SkuRecommendationResult | undefined>;
startPerfDataCollection(ownerUri: string, dataFolder: string, perfQueryIntervalInSec: number, staticQueryIntervalInSec: number, numberOfIterations: number): Promise<StartPerfDataCollectionResult | undefined>; startPerfDataCollection(ownerUri: string, dataFolder: string, perfQueryIntervalInSec: number, staticQueryIntervalInSec: number, numberOfIterations: number): Promise<StartPerfDataCollectionResult | undefined>;
stopPerfDataCollection(): Promise<StopPerfDataCollectionResult | undefined>; stopPerfDataCollection(): Promise<StopPerfDataCollectionResult | undefined>;
@@ -799,10 +799,6 @@ declare module 'mssql' {
assessmentReportPath: string; assessmentReportPath: string;
} }
export interface ISqlMigrationService {
getAssessments(ownerUri: string, databases: string[]): Promise<AssessmentResult | undefined>;
}
export interface CreateSasResponse { export interface CreateSasResponse {
sharedAccessSignature: string; sharedAccessSignature: string;
} }

4
extensions/mssql/src/sqlMigration/sqlMigrationService.ts
View File

@@ -29,8 +29,8 @@ export class SqlMigrationService implements mssql.ISqlMigrationService {
context.registerService(constants.SqlMigrationService, this); context.registerService(constants.SqlMigrationService, this);
} }
async getAssessments(ownerUri: string, databases: string[]): Promise<mssql.AssessmentResult | undefined> { async getAssessments(ownerUri: string, databases: string[], xEventsFilesFolderPath: string): Promise<mssql.AssessmentResult | undefined> {
let params: contracts.SqlMigrationAssessmentParams = { ownerUri: ownerUri, databases: databases }; let params: contracts.SqlMigrationAssessmentParams = { ownerUri: ownerUri, databases: databases, xEventsFilesFolderPath: xEventsFilesFolderPath };
try { try {
return this.client.sendRequest(contracts.GetSqlMigrationAssessmentItemsRequest.type, params); return this.client.sendRequest(contracts.GetSqlMigrationAssessmentItemsRequest.type, params);
} }

3
extensions/sql-migration/src/models/stateMachine.ts
View File

@@ -392,7 +392,8 @@ export class MigrationStateModel implements Model, vscode.Disposable {
public async getDatabaseAssessments(targetType: MigrationTargetType[]): Promise<ServerAssessment> { public async getDatabaseAssessments(targetType: MigrationTargetType[]): Promise<ServerAssessment> {
const ownerUri = await azdata.connection.getUriForConnection(this.sourceConnectionId); const ownerUri = await azdata.connection.getUriForConnection(this.sourceConnectionId);
try { try {
const response = (await this.migrationService.getAssessments(ownerUri, this._databasesForAssessment))!; const xEventsFilesFolderPath = ''; // to-do: collect by prompting the user in the UI - for now, blank = disabled
const response = (await this.migrationService.getAssessments(ownerUri, this._databasesForAssessment, xEventsFilesFolderPath))!;
this._assessmentApiResponse = response; this._assessmentApiResponse = response;
this._assessedDatabaseList = this._databasesForAssessment.slice(); this._assessedDatabaseList = this._databasesForAssessment.slice();