ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-12 02:58:31 -05:00
Code Issues Packages Projects Releases Wiki Activity

Hygiene linting for extensions + new rule (#7843)

Browse Source 
* linting for extensions + new rule

* Remove unneeded array

* Fix spelling mistake

* Fix bad merge
This commit is contained in:
Charles Gagnon
2019-10-22 18:56:31 -07:00
committed by GitHub
parent 4c24043cc8
commit 4a68ab4659
91 changed files with 920 additions and 792 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
extensions/cms/src/cmsResource/cmsResourceCommands.ts
View File

@@ -44,7 +44,7 @@ export function registerCmsServerCommand(appContext: AppContext, tree: CmsResour
tree.notifyNodeChanged(undefined);
} else {
// error out for same server name
let errorText = localize('cms.errors.sameCmsServerName', 'Central Management Server Group already has a Registered Server with the name {0}', registeredCmsServerName);
let errorText = localize('cms.errors.sameCmsServerName', "Central Management Server Group already has a Registered Server with the name {0}", registeredCmsServerName);
appContext.apiWrapper.showErrorMessage(errorText);
throw new Error(errorText);
}
@@ -85,10 +85,10 @@ export function deleteRegisteredServerCommand(appContext: AppContext, tree: CmsR
return;
}
let result = await appContext.apiWrapper.showWarningMessage(
`${localize('cms.confirmDeleteServer', 'Are you sure you want to delete')} ${node.name}?`,
localize('cms.yes', 'Yes'),
localize('cms.no', 'No'));
if (result && result === localize('cms.yes', 'Yes')) {
`${localize('cms.confirmDeleteServer', "Are you sure you want to delete")} ${node.name}?`,
localize('cms.yes', "Yes"),
localize('cms.no', "No"));
if (result && result === localize('cms.yes', "Yes")) {
await appContext.cmsUtils.removeRegisteredServer(node.name, node.relativePath, node.ownerUri);
tree.notifyNodeChanged(node.parent);
}
@@ -102,10 +102,10 @@ export function addServerGroupCommand(appContext: AppContext, tree: CmsResourceT
return;
}
// add a dialog for adding a group
let title = localize('cms.AddServerGroup', 'Add Server Group');
let title = localize('cms.AddServerGroup', "Add Server Group");
let dialog = azdata.window.createModelViewDialog(title, 'cms.addServerGroup');
dialog.okButton.label = localize('cms.OK', 'OK');
dialog.cancelButton.label = localize('cms.Cancel', 'Cancel');
dialog.okButton.label = localize('cms.OK', "OK");
dialog.cancelButton.label = localize('cms.Cancel', "Cancel");
let mainTab = azdata.window.createTab(title);
let serverGroupName: string = null;
let serverDescription: string = null;
@@ -126,10 +126,10 @@ export function addServerGroupCommand(appContext: AppContext, tree: CmsResourceT
let formModel = view.modelBuilder.formContainer()
.withFormItems([{
component: nameTextBox,
title: localize('cms.ServerGroupName', 'Server Group Name')
title: localize('cms.ServerGroupName', "Server Group Name")
}, {
component: descriptionTextBox,
title: localize('cms.ServerGroupDescription', 'Server Group Description')
title: localize('cms.ServerGroupDescription', "Server Group Description")
}]).withLayout({ width: '100%' }).component();
await view.initializeModel(formModel);
});
@@ -146,7 +146,7 @@ export function addServerGroupCommand(appContext: AppContext, tree: CmsResourceT
tree.notifyNodeChanged(node);
} else {
// error out for same server group
const errorText = localize('cms.errors.sameServerGroupName', '{0} already has a Server Group with the name {1}', node.name, serverGroupName);
const errorText = localize('cms.errors.sameServerGroupName', "{0} already has a Server Group with the name {1}", node.name, serverGroupName);
appContext.apiWrapper.showErrorMessage(errorText);
throw new Error(errorText);
}
@@ -161,10 +161,10 @@ export function deleteServerGroupCommand(appContext: AppContext, tree: CmsResour
return;
}
let result = await appContext.apiWrapper.showWarningMessage(
`${localize('cms.confirmDeleteGroup', 'Are you sure you want to delete')} ${node.name}?`,
localize('cms.yes', 'Yes'),
localize('cms.no', 'No'));
if (result && result === localize('cms.yes', 'Yes')) {
`${localize('cms.confirmDeleteGroup', "Are you sure you want to delete")} ${node.name}?`,
localize('cms.yes', "Yes"),
localize('cms.no', "No"));
if (result && result === localize('cms.yes', "Yes")) {
await appContext.cmsUtils.removeServerGroup(node.name, node.relativePath, node.ownerUri);
tree.notifyNodeChanged(node.parent);
}

2
extensions/cms/src/cmsResource/tree/cmsResourceEmptyTreeNode.ts
View File

@@ -47,5 +47,5 @@ export class CmsResourceEmptyTreeNode extends TreeNode {
return 'message_cmsTreeNode';
}
private static readonly addCmsServerLabel = localize('cms.resource.tree.CmsTreeNode.addCmsServerLabel', 'Add Central Management Server...');
private static readonly addCmsServerLabel = localize('cms.resource.tree.CmsTreeNode.addCmsServerLabel', "Add Central Management Server...");
}

2
extensions/cms/src/cmsResource/tree/cmsResourceTreeNode.ts
View File

@@ -128,5 +128,5 @@ export class CmsResourceTreeNode extends CmsResourceTreeNodeBase {
return this._serverGroupNodes;
}
public static readonly noResourcesLabel = localize('cms.resource.cmsResourceTreeNode.noResourcesLabel', 'No resources found');
public static readonly noResourcesLabel = localize('cms.resource.cmsResourceTreeNode.noResourcesLabel', "No resources found");
}

2
extensions/cms/src/cmsResource/tree/treeProvider.ts
View File

@@ -98,5 +98,5 @@ export class CmsResourceTreeProvider implements TreeDataProvider<TreeNode>, ICms
public isSystemInitialized: boolean = false;
private _onDidChangeTreeData = new EventEmitter<TreeNode>();
private static readonly loadingLabel = localize('cms.resource.tree.treeProvider.loadingLabel', 'Loading ...');
private static readonly loadingLabel = localize('cms.resource.tree.treeProvider.loadingLabel', "Loading ...");
}