mirror of
https://github.com/ckaczor/azuredatastudio.git
synced 2026-02-16 10:58:30 -05:00
Hygiene linting for extensions + new rule (#7843)
* linting for extensions + new rule * Remove unneeded array * Fix spelling mistake * Fix bad merge
This commit is contained in:
Charles Gagnon
@@ -15,13 +15,13 @@ import { getTelemetryErrorType, getEndpointName, verifyConnectionAndGetOwnerUri,
|
||||
import { SchemaCompareDialog } from './dialogs/schemaCompareDialog';
|
||||
import { isNullOrUndefined } from 'util';
|
||||
const localize = nls.loadMessageBundle();
|
||||
const diffEditorTitle = localize('schemaCompare.CompareDetailsTitle', 'Compare Details');
|
||||
const applyConfirmation = localize('schemaCompare.ApplyConfirmation', 'Are you sure you want to update the target?');
|
||||
const reCompareToRefeshMessage = localize('schemaCompare.RecompareToRefresh', 'Press Compare to refresh the comparison.');
|
||||
const generateScriptEnabledMessage = localize('schemaCompare.generateScriptEnabledButton', 'Generate script to deploy changes to target');
|
||||
const generateScriptNoChangesMessage = localize('schemaCompare.generateScriptNoChanges', 'No changes to script');
|
||||
const applyEnabledMessage = localize('schemaCompare.applyButtonEnabledTitle', 'Apply changes to target');
|
||||
const applyNoChangesMessage = localize('schemaCompare.applyNoChanges', 'No changes to apply');
|
||||
const diffEditorTitle = localize('schemaCompare.CompareDetailsTitle', "Compare Details");
|
||||
const applyConfirmation = localize('schemaCompare.ApplyConfirmation', "Are you sure you want to update the target?");
|
||||
const reCompareToRefeshMessage = localize('schemaCompare.RecompareToRefresh', "Press Compare to refresh the comparison.");
|
||||
const generateScriptEnabledMessage = localize('schemaCompare.generateScriptEnabledButton', "Generate script to deploy changes to target");
|
||||
const generateScriptNoChangesMessage = localize('schemaCompare.generateScriptNoChanges', "No changes to script");
|
||||
const applyEnabledMessage = localize('schemaCompare.applyButtonEnabledTitle', "Apply changes to target");
|
||||
const applyNoChangesMessage = localize('schemaCompare.applyNoChanges', "No changes to apply");
|
||||
// Do not localize this, this is used to decide the icon for the editor.
|
||||
// TODO : In future icon should be decided based on language id (scmp) and not resource name
|
||||
const schemaCompareResourceName = 'Schema Compare';
|
||||
@@ -75,11 +75,11 @@ export class SchemaCompareMainWindow {
|
||||
|
||||
constructor(private schemaCompareService?: mssql.ISchemaCompareService, private extensionContext?: vscode.ExtensionContext) {
|
||||
this.SchemaCompareActionMap = new Map<Number, string>();
|
||||
this.SchemaCompareActionMap[mssql.SchemaUpdateAction.Delete] = localize('schemaCompare.deleteAction', 'Delete');
|
||||
this.SchemaCompareActionMap[mssql.SchemaUpdateAction.Change] = localize('schemaCompare.changeAction', 'Change');
|
||||
this.SchemaCompareActionMap[mssql.SchemaUpdateAction.Add] = localize('schemaCompare.addAction', 'Add');
|
||||
this.SchemaCompareActionMap[mssql.SchemaUpdateAction.Delete] = localize('schemaCompare.deleteAction', "Delete");
|
||||
this.SchemaCompareActionMap[mssql.SchemaUpdateAction.Change] = localize('schemaCompare.changeAction', "Change");
|
||||
this.SchemaCompareActionMap[mssql.SchemaUpdateAction.Add] = localize('schemaCompare.addAction', "Add");
|
||||
|
||||
this.editor = azdata.workspace.createModelViewEditor(localize('schemaCompare.Title', 'Schema Compare'), { retainContextWhenHidden: true, supportsSave: true, resourceName: schemaCompareResourceName });
|
||||
this.editor = azdata.workspace.createModelViewEditor(localize('schemaCompare.Title', "Schema Compare"), { retainContextWhenHidden: true, supportsSave: true, resourceName: schemaCompareResourceName });
|
||||
}
|
||||
|
||||
public async start(context: any) {
|
||||
@@ -159,17 +159,17 @@ export class SchemaCompareMainWindow {
|
||||
}]);
|
||||
|
||||
let sourceLabel = view.modelBuilder.text().withProperties({
|
||||
value: localize('schemaCompare.sourceLabel', 'Source'),
|
||||
value: localize('schemaCompare.sourceLabel', "Source"),
|
||||
CSSStyles: { 'margin-bottom': '0px' }
|
||||
}).component();
|
||||
|
||||
let targetLabel = view.modelBuilder.text().withProperties({
|
||||
value: localize('schemaCompare.targetLabel', 'Target'),
|
||||
value: localize('schemaCompare.targetLabel', "Target"),
|
||||
CSSStyles: { 'margin-bottom': '0px' }
|
||||
}).component();
|
||||
|
||||
let arrowLabel = view.modelBuilder.text().withProperties({
|
||||
value: localize('schemaCompare.switchLabel', '➔')
|
||||
value: localize('schemaCompare.switchLabel', "➔")
|
||||
}).component();
|
||||
|
||||
this.sourceName = getEndpointName(this.sourceEndpointInfo);
|
||||
@@ -204,15 +204,15 @@ export class SchemaCompareMainWindow {
|
||||
|
||||
this.loader = view.modelBuilder.loadingComponent().component();
|
||||
this.waitText = view.modelBuilder.text().withProperties({
|
||||
value: localize('schemaCompare.waitText', 'Initializing Comparison. This might take a moment.')
|
||||
value: localize('schemaCompare.waitText', "Initializing Comparison. This might take a moment.")
|
||||
}).component();
|
||||
|
||||
this.startText = view.modelBuilder.text().withProperties({
|
||||
value: localize('schemaCompare.startText', 'To compare two schemas, first select a source schema and target schema, then press Compare.')
|
||||
value: localize('schemaCompare.startText', "To compare two schemas, first select a source schema and target schema, then press Compare.")
|
||||
}).component();
|
||||
|
||||
this.noDifferencesLabel = view.modelBuilder.text().withProperties({
|
||||
value: localize('schemaCompare.noDifferences', 'No schema differences were found.')
|
||||
value: localize('schemaCompare.noDifferences', "No schema differences were found.")
|
||||
}).component();
|
||||
|
||||
this.flexModel = view.modelBuilder.flexContainer().component();
|
||||
@@ -298,29 +298,29 @@ export class SchemaCompareMainWindow {
|
||||
data: data,
|
||||
columns: [
|
||||
{
|
||||
value: localize('schemaCompare.typeColumn', 'Type'),
|
||||
value: localize('schemaCompare.typeColumn', "Type"),
|
||||
cssClass: 'align-with-header',
|
||||
width: 50
|
||||
},
|
||||
{
|
||||
value: localize('schemaCompare.sourceNameColumn', 'Source Name'),
|
||||
value: localize('schemaCompare.sourceNameColumn', "Source Name"),
|
||||
cssClass: 'align-with-header',
|
||||
width: 90
|
||||
},
|
||||
{
|
||||
value: localize('schemaCompare.includeColumnName', 'Include'),
|
||||
value: localize('schemaCompare.includeColumnName', "Include"),
|
||||
cssClass: 'align-with-header',
|
||||
width: 60,
|
||||
type: azdata.ColumnType.checkBox,
|
||||
options: { actionOnCheckbox: azdata.ActionOnCellCheckboxCheck.customAction }
|
||||
},
|
||||
{
|
||||
value: localize('schemaCompare.actionColumn', 'Action'),
|
||||
value: localize('schemaCompare.actionColumn', "Action"),
|
||||
cssClass: 'align-with-header',
|
||||
width: 30
|
||||
},
|
||||
{
|
||||
value: localize('schemaCompare.targetNameColumn', 'Target Name'),
|
||||
value: localize('schemaCompare.targetNameColumn', "Target Name"),
|
||||
cssClass: 'align-with-header',
|
||||
width: 150
|
||||
}
|
||||
@@ -348,8 +348,8 @@ export class SchemaCompareMainWindow {
|
||||
this.generateScriptButton.enabled = true;
|
||||
this.applyButton.enabled = true;
|
||||
} else {
|
||||
this.generateScriptButton.title = localize('schemaCompare.generateScriptButtonDisabledTitle', 'Generate script is enabled when the target is a database');
|
||||
this.applyButton.title = localize('schemaCompare.applyButtonDisabledTitle', 'Apply is enabled when the target is a database');
|
||||
this.generateScriptButton.title = localize('schemaCompare.generateScriptButtonDisabledTitle', "Generate script is enabled when the target is a database");
|
||||
this.applyButton.title = localize('schemaCompare.applyButtonDisabledTitle', "Apply is enabled when the target is a database");
|
||||
}
|
||||
} else {
|
||||
this.flexModel.addItem(this.noDifferencesLabel, { CSSStyles: { 'margin': 'auto' } });
|
||||
@@ -541,12 +541,12 @@ export class SchemaCompareMainWindow {
|
||||
|
||||
private createCompareButton(view: azdata.ModelView): void {
|
||||
this.compareButton = view.modelBuilder.button().withProperties({
|
||||
label: localize('schemaCompare.compareButton', 'Compare'),
|
||||
label: localize('schemaCompare.compareButton', "Compare"),
|
||||
iconPath: {
|
||||
light: path.join(this.extensionContext.extensionPath, 'media', 'compare.svg'),
|
||||
dark: path.join(this.extensionContext.extensionPath, 'media', 'compare-inverse.svg')
|
||||
},
|
||||
title: localize('schemaCompare.compareButtonTitle', 'Compare')
|
||||
title: localize('schemaCompare.compareButtonTitle', "Compare")
|
||||
}).component();
|
||||
|
||||
this.compareButton.onDidClick(async (click) => {
|
||||
@@ -556,12 +556,12 @@ export class SchemaCompareMainWindow {
|
||||
|
||||
private createCancelButton(view: azdata.ModelView): void {
|
||||
this.cancelCompareButton = view.modelBuilder.button().withProperties({
|
||||
label: localize('schemaCompare.cancelCompareButton', 'Stop'),
|
||||
label: localize('schemaCompare.cancelCompareButton', "Stop"),
|
||||
iconPath: {
|
||||
light: path.join(this.extensionContext.extensionPath, 'media', 'stop.svg'),
|
||||
dark: path.join(this.extensionContext.extensionPath, 'media', 'stop-inverse.svg')
|
||||
},
|
||||
title: localize('schemaCompare.cancelCompareButtonTitle', 'Stop')
|
||||
title: localize('schemaCompare.cancelCompareButtonTitle', "Stop")
|
||||
}).component();
|
||||
|
||||
this.cancelCompareButton.onDidClick(async (click) => {
|
||||
@@ -604,7 +604,7 @@ export class SchemaCompareMainWindow {
|
||||
|
||||
private createGenerateScriptButton(view: azdata.ModelView): void {
|
||||
this.generateScriptButton = view.modelBuilder.button().withProperties({
|
||||
label: localize('schemaCompare.generateScriptButton', 'Generate script'),
|
||||
label: localize('schemaCompare.generateScriptButton', "Generate script"),
|
||||
iconPath: {
|
||||
light: path.join(this.extensionContext.extensionPath, 'media', 'generate-script.svg'),
|
||||
dark: path.join(this.extensionContext.extensionPath, 'media', 'generate-script-inverse.svg')
|
||||
@@ -635,12 +635,12 @@ export class SchemaCompareMainWindow {
|
||||
|
||||
private createOptionsButton(view: azdata.ModelView) {
|
||||
this.optionsButton = view.modelBuilder.button().withProperties({
|
||||
label: localize('schemaCompare.optionsButton', 'Options'),
|
||||
label: localize('schemaCompare.optionsButton', "Options"),
|
||||
iconPath: {
|
||||
light: path.join(this.extensionContext.extensionPath, 'media', 'options.svg'),
|
||||
dark: path.join(this.extensionContext.extensionPath, 'media', 'options-inverse.svg')
|
||||
},
|
||||
title: localize('schemaCompare.optionsButtonTitle', 'Options')
|
||||
title: localize('schemaCompare.optionsButtonTitle', "Options")
|
||||
}).component();
|
||||
|
||||
this.optionsButton.onDidClick(async (click) => {
|
||||
@@ -655,7 +655,7 @@ export class SchemaCompareMainWindow {
|
||||
private createApplyButton(view: azdata.ModelView) {
|
||||
|
||||
this.applyButton = view.modelBuilder.button().withProperties({
|
||||
label: localize('schemaCompare.updateButton', 'Apply'),
|
||||
label: localize('schemaCompare.updateButton', "Apply"),
|
||||
iconPath: {
|
||||
light: path.join(this.extensionContext.extensionPath, 'media', 'start.svg'),
|
||||
dark: path.join(this.extensionContext.extensionPath, 'media', 'start-inverse.svg')
|
||||
@@ -663,7 +663,7 @@ export class SchemaCompareMainWindow {
|
||||
}).component();
|
||||
|
||||
// need only yes button - since the modal dialog has a default cancel
|
||||
const yesString = localize('schemaCompare.ApplyYes', 'Yes');
|
||||
const yesString = localize('schemaCompare.ApplyYes', "Yes");
|
||||
this.applyButton.onDidClick(async (click) => {
|
||||
|
||||
vscode.window.showWarningMessage(applyConfirmation, { modal: true }, yesString).then(async (result) => {
|
||||
@@ -762,12 +762,12 @@ export class SchemaCompareMainWindow {
|
||||
|
||||
private createSwitchButton(view: azdata.ModelView): void {
|
||||
this.switchButton = view.modelBuilder.button().withProperties({
|
||||
label: localize('schemaCompare.switchDirectionButton', 'Switch direction'),
|
||||
label: localize('schemaCompare.switchDirectionButton', "Switch direction"),
|
||||
iconPath: {
|
||||
light: path.join(this.extensionContext.extensionPath, 'media', 'switch-directions.svg'),
|
||||
dark: path.join(this.extensionContext.extensionPath, 'media', 'switch-directions-inverse.svg')
|
||||
},
|
||||
title: localize('schemaCompare.switchButtonTitle', 'Switch source and target')
|
||||
title: localize('schemaCompare.switchButtonTitle', "Switch source and target")
|
||||
}).component();
|
||||
|
||||
this.switchButton.onDidClick(async (click) => {
|
||||
@@ -835,12 +835,12 @@ export class SchemaCompareMainWindow {
|
||||
|
||||
private createOpenScmpButton(view: azdata.ModelView) {
|
||||
this.openScmpButton = view.modelBuilder.button().withProperties({
|
||||
label: localize('schemaCompare.openScmpButton', 'Open .scmp file'),
|
||||
label: localize('schemaCompare.openScmpButton', "Open .scmp file"),
|
||||
iconPath: {
|
||||
light: path.join(this.extensionContext.extensionPath, 'media', 'open-scmp.svg'),
|
||||
dark: path.join(this.extensionContext.extensionPath, 'media', 'open-scmp-inverse.svg')
|
||||
},
|
||||
title: localize('schemaCompare.openScmpButtonTitle', 'Load source, target, and options saved in an .scmp file')
|
||||
title: localize('schemaCompare.openScmpButtonTitle', "Load source, target, and options saved in an .scmp file")
|
||||
}).component();
|
||||
|
||||
this.openScmpButton.onDidClick(async (click) => {
|
||||
@@ -852,7 +852,7 @@ export class SchemaCompareMainWindow {
|
||||
canSelectFolders: false,
|
||||
canSelectMany: false,
|
||||
defaultUri: vscode.Uri.file(rootPath),
|
||||
openLabel: localize('schemaCompare.openFile', 'Open'),
|
||||
openLabel: localize('schemaCompare.openFile', "Open"),
|
||||
filters: {
|
||||
'scmp Files': ['scmp'],
|
||||
}
|
||||
@@ -932,12 +932,12 @@ export class SchemaCompareMainWindow {
|
||||
|
||||
private createSaveScmpButton(view: azdata.ModelView): void {
|
||||
this.saveScmpButton = view.modelBuilder.button().withProperties({
|
||||
label: localize('schemaCompare.saveScmpButton', 'Save .scmp file'),
|
||||
label: localize('schemaCompare.saveScmpButton', "Save .scmp file"),
|
||||
iconPath: {
|
||||
light: path.join(this.extensionContext.extensionPath, 'media', 'save-scmp.svg'),
|
||||
dark: path.join(this.extensionContext.extensionPath, 'media', 'save-scmp-inverse.svg')
|
||||
},
|
||||
title: localize('schemaCompare.saveScmpButtonTitle', 'Save source and target, options, and excluded elements'),
|
||||
title: localize('schemaCompare.saveScmpButtonTitle', "Save source and target, options, and excluded elements"),
|
||||
enabled: false
|
||||
}).component();
|
||||
|
||||
@@ -946,7 +946,7 @@ export class SchemaCompareMainWindow {
|
||||
const filePath = await vscode.window.showSaveDialog(
|
||||
{
|
||||
defaultUri: vscode.Uri.file(rootPath),
|
||||
saveLabel: localize('schemaCompare.saveFile', 'Save'),
|
||||
saveLabel: localize('schemaCompare.saveFile', "Save"),
|
||||
filters: {
|
||||
'scmp Files': ['scmp'],
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user