ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-26 09:35:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Hygiene linting for extensions + new rule (#7843)

Browse Source 
* linting for extensions + new rule

* Remove unneeded array

* Fix spelling mistake

* Fix bad merge
This commit is contained in:
Charles Gagnon
2019-10-22 18:56:31 -07:00
committed by GitHub
parent 4c24043cc8
commit 4a68ab4659
91 changed files with 920 additions and 792 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/workbench/parts/dashboard/browser/containers/dashboardErrorContainer.component.ts
View File

@@ -40,7 +40,7 @@ export class DashboardErrorContainer extends DashboardTab implements AfterViewIn
ngAfterViewInit() {
const errorMessage = this._errorMessageContainer.nativeElement as HTMLElement;
errorMessage.innerText = nls.localize('dashboardNavSection_loadTabError', "The \"{0}\" section has invalid content. Please contact extension owner.", this.tab.title);
errorMessage.innerText = nls.localize('dashboardNavSection.loadTabError', "The \"{0}\" section has invalid content. Please contact extension owner.", this.tab.title);
}
public get id(): string {

6
src/sql/workbench/parts/dashboard/browser/containers/dashboardNavSection.contribution.ts
View File

@@ -102,12 +102,12 @@ export function validateNavSectionContributionAndRegisterIcon(extension: IExtens
navSectionConfigs.forEach(section => {
if (!section.title) {
result = false;
extension.collector.error(nls.localize('navSection.missingTitle_error', "No title in nav section specified for extension."));
extension.collector.error(nls.localize('navSection.missingTitle.error', "No title in nav section specified for extension."));
}
if (!section.container) {
result = false;
extension.collector.error(nls.localize('navSection.missingContainer_error', "No container in nav section specified for extension."));
extension.collector.error(nls.localize('navSection.missingContainer.error', "No container in nav section specified for extension."));
}
if (Object.keys(section.container).length !== 1) {
@@ -131,7 +131,7 @@ export function validateNavSectionContributionAndRegisterIcon(extension: IExtens
break;
case NAV_SECTION:
result = false;
extension.collector.error(nls.localize('navSection.invalidContainer_error', "NAV_SECTION within NAV_SECTION is an invalid container for extension."));
extension.collector.error(nls.localize('navSection.invalidContainer.error', "NAV_SECTION within NAV_SECTION is an invalid container for extension."));
break;
}