Merge from vscode ad407028575a77ea387eb7cc219b323dc017b686

This commit is contained in:
ADS Merger
2020-08-22 06:06:52 +00:00
committed by Anthony Dresser
parent 404260b8a0
commit 4ad73d381c
480 changed files with 14360 additions and 14122 deletions

View File

@@ -553,7 +553,7 @@ export class IssueReporter extends Disposable {
private clearSearchResults(): void {
const similarIssues = this.getElementById('similar-issues')!;
similarIssues.innerHTML = '';
similarIssues.innerText = '';
this.numberOfSearchResultsDisplayed = 0;
}
@@ -564,7 +564,7 @@ export class IssueReporter extends Disposable {
window.fetch(`https://api.github.com/search/issues?q=${query}`).then((response) => {
response.json().then(result => {
similarIssues.innerHTML = '';
similarIssues.innerText = '';
if (result && result.items) {
this.displaySearchResults(result.items);
} else {
@@ -713,7 +713,7 @@ export class IssueReporter extends Disposable {
}
}
sourceSelect.innerHTML = '';
sourceSelect.innerText = '';
if (issueType === IssueType.FeatureRequest) {
sourceSelect.append(...[
this.makeOption('', localize('selectSource', "Select source"), true),
@@ -812,11 +812,14 @@ export class IssueReporter extends Disposable {
private validateInput(inputId: string): boolean {
const inputElement = (<HTMLInputElement>this.getElementById(inputId));
const inputValidationMessage = this.getElementById(`${inputId}-empty-error`);
if (!inputElement.value) {
inputElement.classList.add('invalid-input');
inputValidationMessage?.classList.remove('hidden');
return false;
} else {
inputElement.classList.remove('invalid-input');
inputValidationMessage?.classList.add('hidden');
return true;
}
}
@@ -1079,7 +1082,7 @@ export class IssueReporter extends Disposable {
}
private updateExtensionTable(extensions: IssueReporterExtensionData[], numThemeExtensions: number): void {
const target = document.querySelector('.block-extensions .block-info');
const target = document.querySelector<HTMLElement>('.block-extensions .block-info');
if (target) {
if (this.configuration.disableExtensions) {
target.innerHTML = localize('disabledExtensions', "Extensions are disabled");
@@ -1090,7 +1093,7 @@ export class IssueReporter extends Disposable {
extensions = extensions || [];
if (!extensions.length) {
target.innerHTML = 'Extensions: none' + themeExclusionStr;
target.innerText = 'Extensions: none' + themeExclusionStr;
return;
}
@@ -1100,10 +1103,10 @@ export class IssueReporter extends Disposable {
}
private updateSearchedExtensionTable(extensions: IssueReporterExtensionData[]): void {
const target = document.querySelector('.block-searchedExtensions .block-info');
const target = document.querySelector<HTMLElement>('.block-searchedExtensions .block-info');
if (target) {
if (!extensions.length) {
target.innerHTML = 'Extensions: none';
target.innerText = 'Extensions: none';
return;
}