ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Re-enable notebook text cell smoke test (#15720)

Browse Source 
* re-enable text cell test

* close notebook after text cell test
This commit is contained in:
Lucy Zhang
2021-06-16 09:20:21 -04:00
committed by GitHub
parent 3315214435
commit 4c039f7a88
3 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/automation/src/sql/notebook.ts
View File

@@ -15,7 +15,6 @@ export class Notebook {
public readonly toolbar: NotebookToolbar; public readonly toolbar: NotebookToolbar;
public readonly view: NotebookView; public readonly view: NotebookView;
private newNotebookCount: number = 0;
constructor(private code: Code, private quickAccess: QuickAccess, private quickInput: QuickInput, private editors: Editors) { constructor(private code: Code, private quickAccess: QuickAccess, private quickInput: QuickInput, private editors: Editors) {
this.toolbar = new NotebookToolbar(code); this.toolbar = new NotebookToolbar(code);
@@ -32,9 +31,8 @@ export class Notebook {
async newUntitledNotebook(): Promise<void> { async newUntitledNotebook(): Promise<void> {
await this.code.dispatchKeybinding(winOrCtrl + '+alt+n'); await this.code.dispatchKeybinding(winOrCtrl + '+alt+n');
await this.editors.waitForActiveTab(`Notebook-${this.newNotebookCount}`); await this.editors.waitForActiveTab(`Notebook-0`);
await this.code.waitForElement('.notebookEditor'); await this.code.waitForElement('.notebookEditor');
this.newNotebookCount++;
} }
// Notebook Toolbar Actions // Notebook Toolbar Actions

8
test/smoke/src/sql/areas/notebook/notebook.test.ts
View File

@@ -22,6 +22,8 @@ export function setup() {
await app.workbench.sqlNotebook.runActiveCell(); await app.workbench.sqlNotebook.runActiveCell();
await app.workbench.sqlNotebook.waitForActiveCellResults(); await app.workbench.sqlNotebook.waitForActiveCellResults();
await app.workbench.quickaccess.runCommand('workbench.action.revertAndCloseActiveEditor');
}); });
it('can open ipynb file, run all, and save notebook with outputs', async function () { it('can open ipynb file, run all, and save notebook with outputs', async function () {
@@ -60,7 +62,7 @@ export function setup() {
await app.workbench.quickaccess.runCommand('workbench.action.closeActiveEditor'); await app.workbench.quickaccess.runCommand('workbench.action.closeActiveEditor');
}); });
it.skip('can perform basic text cell functionality', async function () { it('can perform basic text cell functionality', async function () {
const app = this.app as Application; const app = this.app as Application;
await app.workbench.sqlNotebook.newUntitledNotebook(); await app.workbench.sqlNotebook.newUntitledNotebook();
await app.workbench.sqlNotebook.addCellFromPlaceholder('Markdown'); await app.workbench.sqlNotebook.addCellFromPlaceholder('Markdown');
@@ -76,6 +78,8 @@ export function setup() {
await app.workbench.sqlNotebook.waitForTypeInEditor(sampleText); await app.workbench.sqlNotebook.waitForTypeInEditor(sampleText);
await app.code.dispatchKeybinding('escape'); await app.code.dispatchKeybinding('escape');
await app.workbench.sqlNotebook.waitForTextCellPreviewContent(sampleText, 'p'); await app.workbench.sqlNotebook.waitForTextCellPreviewContent(sampleText, 'p');
await app.workbench.quickaccess.runCommand('workbench.action.revertAndCloseActiveEditor');
}); });
}); });
} }
@@ -95,4 +99,6 @@ async function openAndRunNotebook(app: Application, filename: string): Promise<v
await app.workbench.sqlNotebook.openFile(filename); await app.workbench.sqlNotebook.openFile(filename);
await app.workbench.sqlNotebook.waitForKernel('Python 3'); await app.workbench.sqlNotebook.waitForKernel('Python 3');
await app.workbench.sqlNotebook.waitForAllResults(); await app.workbench.sqlNotebook.waitForAllResults();
await app.workbench.quickaccess.runCommand('workbench.action.revertAndCloseActiveEditor');
} }

2
test/smoke/src/sql/areas/queryEditor/queryEditor.test.ts
View File

@@ -21,6 +21,8 @@ export function setup() {
await app.workbench.connectionDialog.connect(); await app.workbench.connectionDialog.connect();
await app.workbench.queryEditor.commandBar.run(); await app.workbench.queryEditor.commandBar.run();
await app.workbench.queryEditor.waitForResults(); await app.workbench.queryEditor.waitForResults();
await app.workbench.quickaccess.runCommand('workbench.action.revertAndCloseActiveEditor');
}); });
}); });
} }