Dashboard agent tab style updates (#1934)

This commit is contained in:
Karl Burtram
2018-07-15 10:51:20 -07:00
committed by GitHub
parent 74c4b7311e
commit 4d67eca8bb
6 changed files with 42 additions and 7 deletions

View File

@@ -117,7 +117,7 @@ export class JobData implements IAgentDialogData {
if (!result || !result.success) {
vscode.window.showErrorMessage(
localize('alertData.saveErrorMessage', "Alert update failed '{0}'", result.errorMessage ? result.errorMessage : 'Unknown'));
localize('jobData.saveErrorMessage', "Job update failed '{0}'", result.errorMessage ? result.errorMessage : 'Unknown'));
}
}

View File

@@ -35,7 +35,6 @@ export class ProxyData implements IAgentDialogData {
public async save() {
let agentService = await AgentUtils.getAgentService();
let result = await agentService.createProxy(this.ownerUri, this.toAgentProxyInfo());
console.log(result);
if (!result || !result.success) {
// TODO handle error here
}

View File

@@ -204,7 +204,7 @@ export class JobDialog extends AgentDialog<JobData> {
this.StepsTable_FailureColumnString
],
data: [],
height: 300
height: 430
}).component();
this.moveStepUpButton = view.modelBuilder.button()
@@ -261,7 +261,7 @@ export class JobDialog extends AgentDialog<JobData> {
this.AlertNameLabelString
],
data: [],
height: 300,
height: 430,
width: 400
}).component();
@@ -296,7 +296,7 @@ export class JobDialog extends AgentDialog<JobData> {
this.ScheduleNameLabelString
],
data: [],
height: 300,
height: 430,
width: 420
}).component();

View File

@@ -3,6 +3,8 @@
* Licensed under the Source EULA. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
'use strict';
import * as nls from 'vscode-nls';
import * as sqlops from 'sqlops';
import * as vscode from 'vscode';
import { AlertDialog } from './dialogs/alertDialog';
@@ -12,6 +14,8 @@ import { ProxyDialog } from './dialogs/proxyDialog';
import { JobStepDialog } from './dialogs/jobStepDialog';
import { PickScheduleDialog } from './dialogs/pickScheduleDialog';
const localize = nls.loadMessageBundle();
/**
* The main controller class that initializes the extension
*/
@@ -23,6 +27,11 @@ export class MainController {
this._context = context;
}
public static showNotYetImplemented(): void {
vscode.window.showInformationMessage(
localize('mainController.notImplemented', "This feature is under development. Check-out the latest insiders build if you'd like to try out the most recent changes!"));
}
/**
* Activates the extension
*/
@@ -48,8 +57,10 @@ export class MainController {
dialog.openDialog();
});
vscode.commands.registerCommand('agent.openProxyDialog', (ownerUri: string, proxyInfo: sqlops.AgentProxyInfo, credentials: sqlops.CredentialInfo[]) => {
let dialog = new ProxyDialog(ownerUri, proxyInfo, credentials);
dialog.openDialog();
//@TODO: reenable create proxy after snapping July release (7/14/18)
// let dialog = new ProxyDialog(ownerUri, proxyInfo, credentials);
// dialog.openDialog();
MainController.showNotYetImplemented();
});
}