ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-19 17:22:48 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fixing bugs for migration extension private preview 1. (#14872)

Browse Source 
* Fixing Database backup page target layout

* Filtering out Azure sql db issues from assessment results
Correcting the database count for issued databases in sku rec page.

* Adding copy migration details button to migration status

* Adding start migration button to toolbar

* Fixing a syntax error in package.json

* Adding rg and location to target selection page
Filtering storage account by target location.

* Fixing dashboard title to azure sql migration

* Not making assessment targets selected by default.

* Adding tooltip for database and instance table items.

* Fixing duplicate task widget

* Some fixes mentioned in the PR
Localizing button text
renaming  a var
changing null to undefined.

* Adding enum for Migration target types

* Fixing a critical multi db migration bug because of unhandled race condition

* Adding Azure location api to azure core

* Adding source database info in status
This commit is contained in:
Aasim Khan
2021-03-26 10:32:28 -07:00
committed by GitHub
parent e0f24cc268
commit 4d78aefe57
15 changed files with 336 additions and 198 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
extensions/sql-migration/src/dialog/assessmentResults/sqlDatabasesTree.ts
View File

@@ -166,14 +166,14 @@ export class SqlDatabaseTree {
{
displayName: constants.INSTANCE,
valueType: azdata.DeclarativeDataType.component,
width: 150,
width: 130,
isReadOnly: true,
headerCssStyles: headerLeft
},
{
displayName: constants.WARNINGS,
valueType: azdata.DeclarativeDataType.string,
width: 50,
width: 30,
isReadOnly: true,
headerCssStyles: headerRight
}
@@ -595,9 +595,9 @@ export class SqlDatabaseTree {
public selectedDbs(): string[] {
let result: string[] = [];
this._databaseTable.dataValues?.forEach((arr) => {
this._databaseTable.dataValues?.forEach((arr, index) => {
if (arr[0].value === true) {
result.push(arr[1].value.toString());
result.push(this._dbNames[index]);
}
});
return result;
@@ -615,8 +615,6 @@ export class SqlDatabaseTree {
);
});
this._assessmentResultsTable.dataValues = assessmentResults;
this._selectedIssue = this._activeIssues[0];
this.refreshAssessmentDetails();
}
public refreshAssessmentDetails(): void {
@@ -734,14 +732,8 @@ export class SqlDatabaseTree {
);
});
}
this._dbName.value = this._serverName;
this._instanceTable.dataValues = instanceTableValues;
this._databaseTable.dataValues = databaseTableValues;
if (this._targetType === MigrationTargetType.SQLMI) {
this._activeIssues = this._model._assessmentResults.issues;
this._selectedIssue = this._model._assessmentResults?.issues[0];
this.refreshResults();
}
}
private createIconTextCell(icon: IconPath, text: string): azdata.FlexContainer {
@@ -755,8 +747,10 @@ export class SqlDatabaseTree {
}).component();
const textComponent = this._view.modelBuilder.text().withProps({
value: text,
title: text,
CSSStyles: {
'margin': '0px'
'margin': '0px',
'width': '110px'
}
}).component();