From 4dfedabbc6c24c234bfdb16d603bb7426a4b1aa9 Mon Sep 17 00:00:00 2001 From: Cory Rivera Date: Tue, 29 Nov 2022 10:06:52 -0800 Subject: [PATCH] Dispose underlying text input in notebook input to clear editor service references correctly. (#21318) --- .../workbench/contrib/notebook/browser/models/notebookInput.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/sql/workbench/contrib/notebook/browser/models/notebookInput.ts b/src/sql/workbench/contrib/notebook/browser/models/notebookInput.ts index ad3d3319d5..85457f167a 100644 --- a/src/sql/workbench/contrib/notebook/browser/models/notebookInput.ts +++ b/src/sql/workbench/contrib/notebook/browser/models/notebookInput.ts @@ -257,6 +257,7 @@ export abstract class NotebookInput extends EditorInput implements INotebookInpu this._notebookEditorOpenedTimestamp = Date.now(); if (this._textInput) { this.hookDirtyListener(this._textInput.onDidChangeDirty, () => this._onDidChangeDirty.fire()); + this._register(this._textInput); } }