ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-16 09:35:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add support for adding new setting in local.settings.json in add SQL binding quickpick (#17093)

Browse Source 
* be able to add new setting in local.settings.json

* cleanup

* addressing comments

* remove todo comment

* addressing comments

* update some strings to uris
This commit is contained in:
Kim Santiago
2021-09-22 14:12:01 -07:00
committed by GitHub
parent 56e9feba1b
commit 4e5c99df02
5 changed files with 134 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
extensions/sql-database-projects/src/test/packageHelper.test.ts
View File

@@ -27,27 +27,27 @@ describe('PackageHelper tests', function (): void {
it('Should construct correct add Package Arguments', function (): void {
const packageHelper = new PackageHelper( vscode.window.createOutputChannel('db project test'));
const projectPath = 'dummy\\project\\path.csproj';
const result = packageHelper.constructAddPackageArguments(projectPath, constants.sqlExtensionPackageName);
const projectUri = vscode.Uri.file('dummy\\project\\path.csproj');
const result = packageHelper.constructAddPackageArguments(projectUri, constants.sqlExtensionPackageName);
if (os.platform() === 'win32') {
should(result).equal(` add "dummy\\\\project\\\\path.csproj" package ${constants.sqlExtensionPackageName} --prerelease`);
should(result).equal(` add "\\\\dummy\\\\project\\\\path.csproj" package ${constants.sqlExtensionPackageName} --prerelease`);
}
else {
should(result).equal(` add "dummy/project/path.csproj" package ${constants.sqlExtensionPackageName} --prerelease`);
should(result).equal(` add "/dummy/project/path.csproj" package ${constants.sqlExtensionPackageName} --prerelease`);
}
});
it('Should construct correct add Package Arguments with version', function (): void {
const packageHelper = new PackageHelper( vscode.window.createOutputChannel('db project test'));
const projectPath = 'dummy\\project\\path.csproj';
const result = packageHelper.constructAddPackageArguments(projectPath, constants.sqlExtensionPackageName, constants.VersionNumber);
const projectUri = vscode.Uri.file('dummy\\project\\path.csproj');
const result = packageHelper.constructAddPackageArguments(projectUri, constants.sqlExtensionPackageName, constants.VersionNumber);
if (os.platform() === 'win32') {
should(result).equal(` add "dummy\\\\project\\\\path.csproj" package ${constants.sqlExtensionPackageName} -v ${constants.VersionNumber}`);
should(result).equal(` add "\\\\dummy\\\\project\\\\path.csproj" package ${constants.sqlExtensionPackageName} -v ${constants.VersionNumber}`);
}
else {
should(result).equal(` add "dummy/project/path.csproj" package ${constants.sqlExtensionPackageName} -v ${constants.VersionNumber}`);
should(result).equal(` add "/dummy/project/path.csproj" package ${constants.sqlExtensionPackageName} -v ${constants.VersionNumber}`);
}
});
@@ -55,7 +55,7 @@ describe('PackageHelper tests', function (): void {
sinon.stub(azureFunctionUtils, 'getAFProjectContainingFile').resolves(undefined);
const spy = sinon.spy(vscode.window, 'showInformationMessage');
await packageHelper.addPackageToAFProjectContainingFile('', constants.sqlExtensionPackageName);
await packageHelper.addPackageToAFProjectContainingFile(vscode.Uri.file(''), constants.sqlExtensionPackageName);
should(spy.calledOnce).be.true('showInformationMessage should have been called exactly once');
});
});