From 4ece9b0085b6efcb11322a8e4ea3b7c429765fe1 Mon Sep 17 00:00:00 2001
From: Anthony Dresser <andresse@microsoft.com>
Date: Tue, 9 Apr 2019 01:08:56 -0700
Subject: [PATCH] remove dispose of button listeners (#4914)

---
 src/sql/workbench/browser/modal/modal.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/sql/workbench/browser/modal/modal.ts b/src/sql/workbench/browser/modal/modal.ts
index a8d6ac701a..1ab282c1dd 100644
--- a/src/sql/workbench/browser/modal/modal.ts
+++ b/src/sql/workbench/browser/modal/modal.ts
@@ -384,7 +384,7 @@ export abstract class Modal extends Disposable implements IThemable {
 		let footerButton = DOM.$('.footer-button');
 		let button = new Button(footerButton);
 		button.label = label;
-		this._register(button.onDidClick(() => onSelect()));
+		button.onDidClick(() => onSelect()); // @todo this should be registered to dispose but that brakes some dialogs
 		if (orientation === 'left') {
 			DOM.append(this._leftFooter, footerButton);
 		} else {