ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

handle error scenarios for validity check (#24393)

Browse Source
This commit is contained in:
Alan Ren
2023-09-13 09:40:50 -07:00
committed by GitHub
parent df481311ed
commit 4f155423dc
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/sql/workbench/browser/modelComponents/componentBase.ts
View File

@@ -298,9 +298,16 @@ export abstract class ContainerBase<T, TPropertyBag extends azdata.ContainerProp
this._validations.push(() => { this._validations.push(() => {
this.logService.debug(`Running container validation on component ${this.descriptor.id} to check validity of all child items`); this.logService.debug(`Running container validation on component ${this.descriptor.id} to check validity of all child items`);
return this.items.every(item => { return this.items.every(item => {
const valid = this.modelStore.getComponent(item.descriptor.id)?.valid; const component = this.modelStore.getComponent(item.descriptor.id);
if (component === undefined) {
this.logService.warn(`Child item ${item.descriptor.id} of type ${item.descriptor.type} is undefined`);
} else if (component.valid === undefined) {
this.logService.warn(`The validity of child item ${item.descriptor.id} of type ${item.descriptor.type} undefined`);
}
// if the component is not found or the `valid` property is not set, we should treat it as valid.
const valid = component?.valid ?? true;
this.logService.debug(`Child item ${item.descriptor.id} validity is ${valid}`); this.logService.debug(`Child item ${item.descriptor.id} validity is ${valid}`);
return valid || false; return valid;
}); });
}); });
} }