From 4f69ed5745396fb7335f220529b6c516190c2e68 Mon Sep 17 00:00:00 2001 From: Charles Gagnon Date: Tue, 12 Nov 2019 16:31:39 -0800 Subject: [PATCH] Fix missing icon and add test (#8307) * Fix missing icon and add test * Remove debug statement --- src/sql/base/test/node/ui/codicon.test.ts | 27 +++++++++++++++++++ .../browser/queryHistoryActions.ts | 2 +- 2 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 src/sql/base/test/node/ui/codicon.test.ts diff --git a/src/sql/base/test/node/ui/codicon.test.ts b/src/sql/base/test/node/ui/codicon.test.ts new file mode 100644 index 0000000000..dd9032846c --- /dev/null +++ b/src/sql/base/test/node/ui/codicon.test.ts @@ -0,0 +1,27 @@ +/*--------------------------------------------------------------------------------------------- + * Copyright (c) Microsoft Corporation. All rights reserved. + * Licensed under the Source EULA. See License.txt in the project root for license information. + *--------------------------------------------------------------------------------------------*/ + +import * as assert from 'assert'; +import { readFile } from 'vs/base/node/pfs'; +import { join } from 'vs/base/common/path'; +import { URI } from 'vs/base/common/uri'; + +const icons: string[] = [ + 'codicon-chevron-down', + 'codicon-chevron-up', + 'codicon-clear-all', + 'codicon-debug-pause', + 'codicon-play' +]; + +suite('codicon css', () => { + test('codicon.css contains expected icons', async () => { + const codiconFile = await readFile(join(URI.parse(__dirname).fsPath, '..', '..', '..', '..', '..', 'vs', 'base', 'browser', 'ui', 'codiconLabel', 'codicon', 'codicon.css')); + icons.forEach(icon => { + assert.ok(codiconFile.includes(icon), `codicon.css did not contain expected icon ${icon}`); + }); + }); +}); + diff --git a/src/sql/workbench/parts/queryHistory/browser/queryHistoryActions.ts b/src/sql/workbench/parts/queryHistory/browser/queryHistoryActions.ts index 8459a7b73e..125918c378 100644 --- a/src/sql/workbench/parts/queryHistory/browser/queryHistoryActions.ts +++ b/src/sql/workbench/parts/queryHistory/browser/queryHistoryActions.ts @@ -127,7 +127,7 @@ export class ToggleQueryHistoryCaptureAction extends Action { private setClassAndLabel(enabled: boolean) { if (enabled) { - this.class = 'toggle-query-history-capture-action codicon-pause'; + this.class = 'toggle-query-history-capture-action codicon-debug-pause'; this.label = localize('queryHistory.disableCapture', "Pause Query History Capture"); } else { this.class = 'toggle-query-history-capture-action codicon-play';