ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-02 09:35:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

More dangling promise cleanup (#8518)

Browse Source 
* More dangling promise cleanup

* return void

* Function to async

* Fix a couple missed promises
This commit is contained in:
Charles Gagnon
2019-12-02 15:54:33 -08:00
committed by GitHub
parent 8cc60fde90
commit 4f8ced1f6b
8 changed files with 81 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/workbench/contrib/tasks/browser/tasksView.ts
View File

@@ -97,7 +97,7 @@ export class TaskHistoryView extends Disposable {
}
private updateTask(task: TaskNode): void {
this._tree.refresh(task);
this._tree.refresh(task).catch(err => errors.onUnexpectedError(err));
}
public refreshTree(): void {

4
src/sql/workbench/contrib/tasks/common/tasksAction.ts
View File

@@ -57,12 +57,12 @@ export class ScriptAction extends Action {
super(id, label);
}
public run(element: TaskNode): Promise<boolean> {
public async run(element: TaskNode): Promise<boolean> {
if (element instanceof TaskNode) {
if (element.script && element.script !== '') {
this._queryEditorService.newSqlEditor(element.script);
}
}
return Promise.resolve(true);
return true;
}
}