ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-11 18:48:33 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add target platform dropdown to new project dialog (#16091)

Browse Source 
* add target platform as an option in create project api

* move constant

* WIP

* show versions in dialog and create project with selected version

* validate version

* add error messages

* add test

* change version to target platform

* cleanup

* more cleanup

* use withProps
This commit is contained in:
Kim Santiago
2021-07-15 13:43:48 -07:00
committed by GitHub
parent 2a74ad4190
commit 5059c94adc
9 changed files with 150 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
extensions/data-workspace/src/test/dialogs/newProjectDialog.test.ts
View File

@@ -12,6 +12,7 @@ import { promises as fs } from 'fs';
import { NewProjectDialog } from '../../dialogs/newProjectDialog';
import { WorkspaceService } from '../../services/workspaceService';
import { testProjectType } from '../testUtils';
import { IProjectType } from 'dataworkspace';
suite('New Project Dialog', function (): void {
this.afterEach(() => {
@@ -39,5 +40,54 @@ suite('New Project Dialog', function (): void {
dialog.model.name = `TestProject_${new Date().getTime()}`;
should.equal(await dialog.validate(), true, 'Validation should pass because name is unique and parent directory exists');
});
test('Should select correct target platform if provided default', async function (): Promise<void> {
const projectTypeWithTargetPlatforms: IProjectType = {
id: 'tp2',
description: '',
projectFileExtension: 'testproj2',
icon: '',
displayName: 'test project 2',
targetPlatforms: ['platform1', 'platform2', 'platform3'],
defaultTargetPlatform: 'platform2'
};
const workspaceServiceMock = TypeMoq.Mock.ofType<WorkspaceService>();
workspaceServiceMock.setup(x => x.getAllProjectTypes()).returns(() => Promise.resolve([projectTypeWithTargetPlatforms]));
const dialog = new NewProjectDialog(workspaceServiceMock.object);
await dialog.open();
should.equal(dialog.model.targetPlatform, 'platform2', 'Target platform should be platform2');
});
test('Should handle invalid default target platform', async function (): Promise<void> {
const projectTypeWithTargetPlatforms: IProjectType = {
id: 'tp2',
description: '',
projectFileExtension: 'testproj2',
icon: '',
displayName: 'test project 2',
targetPlatforms: ['platform1', 'platform2', 'platform3'],
defaultTargetPlatform: 'invalid'
};
const workspaceServiceMock = TypeMoq.Mock.ofType<WorkspaceService>();
workspaceServiceMock.setup(x => x.getAllProjectTypes()).returns(() => Promise.resolve([projectTypeWithTargetPlatforms]));
const dialog = new NewProjectDialog(workspaceServiceMock.object);
await dialog.open();
should.equal(dialog.model.targetPlatform, 'platform1', 'Target platform should be platform1 (the first value in target platforms)');
});
test('Should handle no target platforms provided by project type', async function (): Promise<void> {
const workspaceServiceMock = TypeMoq.Mock.ofType<WorkspaceService>();
workspaceServiceMock.setup(x => x.getAllProjectTypes()).returns(() => Promise.resolve([testProjectType]));
const dialog = new NewProjectDialog(workspaceServiceMock.object);
await dialog.open();
should.equal(dialog.model.targetPlatform, undefined, 'Target platform should be undefined');
});
});