Fix saved queries opening in plain text editor (#18096)

This commit is contained in:
Charles Gagnon
2022-01-18 12:03:54 -08:00
committed by GitHub
parent eadde49af9
commit 51b0e9feee
2 changed files with 6 additions and 3 deletions

View File

@@ -1157,9 +1157,12 @@ export class ConnectionManagementService extends Disposable implements IConnecti
}
/**
* Replaces connection info uri with new uri.
* Replaces connection info uri with new uri. No-op if the URI does not currently have an associated connection.
*/
public changeConnectionUri(newUri: string, oldUri: string): void {
if (!this._connectionStatusManager.hasConnection(oldUri)) {
return;
}
this._connectionStatusManager.changeConnectionUri(newUri, oldUri);
if (!this._uriToProvider[oldUri]) {
this._logService.error(`No provider found for old URI : '${oldUri}'`);

View File

@@ -435,8 +435,8 @@ export class QueryModelService implements IQueryModelService {
// Get existing query runner
let queryRunner = this.internalGetQueryRunner(oldUri);
if (!queryRunner) {
this._logService.error(`A Query and QueryRunner was not found for '${oldUri}'`);
throw new Error(nls.localize('queryModelService.noQueryFoundForUri', 'No Query found for {0}', oldUri));
// Nothing to do if we don't have a query runner currently (no connection)
return;
}
else if (this._queryInfoMap.has(newUri)) {
this._logService.error(`New URI '${newUri}' already has query info associated with it.`);