ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix database not getting set correctly in DacFx wizard deploy scenario (#3641)

Browse Source 
* fix db not getting set correctly for deploy scenario if coming from import page

* removed space so that comments go directly after //
This commit is contained in:
kisantia
2018-12-19 18:45:40 -05:00
committed by GitHub
parent db145b4999
commit 5367101330
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
extensions/import/src/wizard/pages/deployConfigPage.ts
View File

@@ -131,7 +131,7 @@ export class DeployConfigPage extends DacFxConfigPage {
this.model.database = this.databaseTextBox.value; this.model.database = this.databaseTextBox.value;
}); });
// Initialize with upgrade existing true //Initialize with upgrade existing true
upgradeRadioButton.checked = true; upgradeRadioButton.checked = true;
this.model.upgradeExisting = true; this.model.upgradeExisting = true;
@@ -152,7 +152,7 @@ export class DeployConfigPage extends DacFxConfigPage {
this.databaseDropdown = this.view.modelBuilder.dropDown().withProperties({ this.databaseDropdown = this.view.modelBuilder.dropDown().withProperties({
required: true required: true
}).component(); }).component();
// Handle database changes //Handle database changes
this.databaseDropdown.onValueChanged(async () => { this.databaseDropdown.onValueChanged(async () => {
this.model.database = (<sqlops.CategoryValue>this.databaseDropdown.value).name; this.model.database = (<sqlops.CategoryValue>this.databaseDropdown.value).name;
}); });
@@ -172,7 +172,8 @@ export class DeployConfigPage extends DacFxConfigPage {
} }
let values = await this.getDatabaseValues(); let values = await this.getDatabaseValues();
if (this.model.database === undefined) { //set the database to the first dropdown value if upgrading, otherwise it should get set to the textbox value
if (this.model.upgradeExisting) {
this.model.database = values[0].name; this.model.database = values[0].name;
} }