From 53ec7585a9da594c2465bfffa01238d1efc190a7 Mon Sep 17 00:00:00 2001 From: v-bbrady <60623315+v-bbrady@users.noreply.github.com> Date: Tue, 21 Jul 2020 19:08:05 -0700 Subject: [PATCH] adds role of button to all links that are buttons (#11465) --- .../page/browser/az_data_welcome_page.ts | 19 +++++++++---------- .../welcome/page/browser/welcomePage.ts | 6 ++++++ 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/src/sql/workbench/contrib/welcome/page/browser/az_data_welcome_page.ts b/src/sql/workbench/contrib/welcome/page/browser/az_data_welcome_page.ts index a04183f9df..24b960d0cd 100644 --- a/src/sql/workbench/contrib/welcome/page/browser/az_data_welcome_page.ts +++ b/src/sql/workbench/contrib/welcome/page/browser/az_data_welcome_page.ts @@ -13,14 +13,14 @@ export default () => `
-

Preview

 +

Preview
- +

${escape(localize('welcomePage.createConnection', "Create a connection"))}

${escape(localize('welcomePage.createConnectionBody', "Connect to a database instance through the connection dialog."))}

@@ -60,7 +60,7 @@ export default () => `
-

${escape(localize('welcomePage.runQuery', "Run a query"))}

@@ -70,7 +70,7 @@ export default () => `
- +

${escape(localize('welcomePage.createNotebook', "Create a notebook"))}

${escape(localize('welcomePage.createNotebookBody', "Build a new notebook using a native notebook editor."))}

@@ -79,7 +79,7 @@ export default () => `
- +

${escape(localize('welcomePage.deployServer', "Deploy a server"))}

${escape(localize('welcomePage.deployServerBody', "Create a new instance of SQL Server on the platform of your choice."))}

@@ -109,7 +109,7 @@ export default () => `

No recent folders

- ${escape(localize('welcomePage.moreRecent', "Show more"))} + ${escape(localize('welcomePage.moreRecent', "Show more"))}
@@ -165,8 +165,7 @@ export default () => `

Extend your data studio

- ${escape(localize('welcomePage.showAll', "Show All"))} - ${escape(localize('welcomePage.showAll', "Show All"))} + ${escape(localize('welcomePage.showAll', "Show All"))}
diff --git a/src/sql/workbench/contrib/welcome/page/browser/welcomePage.ts b/src/sql/workbench/contrib/welcome/page/browser/welcomePage.ts index 53db043213..74842276b2 100644 --- a/src/sql/workbench/contrib/welcome/page/browser/welcomePage.ts +++ b/src/sql/workbench/contrib/welcome/page/browser/welcomePage.ts @@ -387,6 +387,7 @@ class WelcomePage extends Disposable { let openFileButton = this._register(new Button(fileBtnContainer)); openFileButton.label = openFileText; const getNewFileBtn = container.querySelector('#open-file-btn-container .monaco-button') as HTMLAnchorElement; + getNewFileBtn.setAttribute('role', 'button'); const body = document.querySelector('body'); if (body.classList.contains('windows') || body.classList.contains('linux')) { @@ -416,6 +417,7 @@ class WelcomePage extends Disposable { let startTourBtn = new Button(containerRight); startTourBtn.label = localize('welcomePage.startTour', "Start Tour"); const removeTourBtn = document.createElement('a'); + removeTourBtn.setAttribute('role', 'button'); const removeBtnClasses = ['btn-remove-tour', 'codicon', 'codicon-close']; const flexClassesLeft = ['flex', 'flex-a-center']; const flexClassesRight = ['flex', 'flex-a-start']; @@ -656,6 +658,7 @@ class WelcomePage extends Disposable { a.innerText = name; a.title = relativePath; a.setAttribute('aria-label', localize('welcomePage.openFolderWithPath', "Open folder {0} with path {1}", name, parentPath)); + a.setAttribute('role', 'button'); a.href = 'javascript:void(0)'; a.addEventListener('click', e => { @@ -717,6 +720,7 @@ class WelcomePage extends Disposable { const bodyElm = document.createElement('p'); outerAnchorContainerElm.classList.add('extension'); outerAnchorContainerElm.classList.add('tile'); + outerAnchorContainerElm.setAttribute('role', 'button'); outerAnchorContainerElm.href = extension.link; flexDivContainerElm.classList.add(...flexDivContainerClasses); descriptionContainerElm.classList.add('description'); @@ -752,6 +756,7 @@ class WelcomePage extends Disposable { getDropdownBtn.title = extension.title || (extension.isKeymap ? localize('welcomePage.installKeymap', "Install {0} keymap", extension.name) : localize('welcomePage.installExtensionPack', "Install additional support for {0}", extension.name)); getDropdownBtn.setAttribute('aria-haspopup', 'true'); getDropdownBtn.setAttribute('aria-controls', 'dropdown'); + getDropdownBtn.setAttribute('role', 'navigation'); getDropdownBtn.id = 'dropdown-btn'; getDropdownBtn.classList.add('installExtension'); getDropdownBtn.setAttribute('data-extension', extension.id); @@ -798,6 +803,7 @@ class WelcomePage extends Disposable { const outerContainerClasses = ['extension-pack-extension-container', 'flex', 'flex-j-center']; const flexContainerClasses = ['flex', 'flex-a-center']; anchorElem.href = j.link; + anchorElem.setAttribute('role', 'button'); outerContainerElem.classList.add(...outerContainerClasses); flexContainerElem.classList.add(...flexContainerClasses); iconContainerElem.classList.add('icon');