Revert "Revert "Remove typings and replace missing methods with vscodes (#8217)"" (#8242)

* Revert "Revert "Remove typings and replace missing methods with vscodes (#8217)" (#8240)"

This reverts commit e801a04bcf.

* fix runtime error

* add tests for chartview
This commit is contained in:
Anthony Dresser
2019-11-06 15:00:34 -08:00
committed by GitHub
parent df6b6ded33
commit 564f78b6f6
185 changed files with 670 additions and 43395 deletions

View File

@@ -85,7 +85,7 @@ suite('TableDataView', () => {
const ret = new Array<number>();
for (let i = 0; i < columnCount; i++) {
const colVal = val[getColumnName(i)];
if (colVal && colVal.toLocaleLowerCase().includes(exp.toLocaleLowerCase())) {
if (colVal && colVal.toLocaleLowerCase().indexOf(exp.toLocaleLowerCase()) > -1) {
ret.push(i);
}
}
@@ -118,7 +118,7 @@ suite('TableDataView', () => {
const ret = new Array<number>();
for (let i = 0; i < columnCount; i++) {
const colVal = val[getColumnName(i)];
if (colVal && colVal.toLocaleLowerCase().includes(exp.toLocaleLowerCase())) {
if (colVal && colVal.toLocaleLowerCase().indexOf(exp.toLocaleLowerCase()) > -1) {
ret.push(i);
}
}
@@ -156,7 +156,7 @@ suite('TableDataView', () => {
const ret = new Array<number>();
for (let i = 0; i < columnCount; i++) {
const colVal = val[getColumnName(i)];
if (colVal && colVal.toLocaleLowerCase().includes(exp.toLocaleLowerCase())) {
if (colVal && colVal.toLocaleLowerCase().indexOf(exp.toLocaleLowerCase()) > -1) {
ret.push(i);
}
}

View File

@@ -4,6 +4,7 @@
*--------------------------------------------------------------------------------------------*/
import * as assert from 'assert';
import { find } from 'vs/base/common/arrays';
export class EventVerifierSingle<T> {
private _eventArgument: T;
@@ -64,13 +65,13 @@ export class EventVerifierMultiple<T> {
public assertFired(expectedArgument?: T) {
assert.ok(this.eventFired);
if (expectedArgument) {
assert.ok(this._eventArguments.includes(expectedArgument));
assert.ok(this._eventArguments.some(x => x === expectedArgument));
}
}
public assertNotFired(expectedArgument?: T) {
if (expectedArgument) {
assert.ok(!this._eventArguments.includes(expectedArgument));
assert.ok(!this._eventArguments.some(x => x === expectedArgument));
} else {
assert.ok(!this.eventFired);
}