More layering and compile strictness (#8973)

* add more folders to strictire compile, add more strict compile options

* update ci

* wip

* add more layering and fix issues

* add more strictness

* remove unnecessary assertion

* add missing checks

* fix indentation

* remove jsdoc

src/sql/workbench/contrib/charts/browser/chartTab.ts

@@ -5,7 +5,7 @@
 
 import { IPanelTab } from 'sql/base/browser/ui/panel/panel';
 import { ChartView } from './chartView';
-import QueryRunner from 'sql/platform/query/common/queryRunner';
+import QueryRunner from 'sql/workbench/services/query/common/queryRunner';
 
 import { localize } from 'vs/nls';
 import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
@@ -34,4 +34,4 @@ export class ChartTab implements IPanelTab {
 	public clear() {
 		this.view.clear();
 	}
-}
+}

src/sql/workbench/contrib/charts/browser/chartView.ts

@@ -7,10 +7,9 @@ import 'vs/css!./media/chartView';
 
 import { IPanelView } from 'sql/base/browser/ui/panel/panel';
 import { Insight } from './insight';
-import QueryRunner from 'sql/platform/query/common/queryRunner';
+import QueryRunner from 'sql/workbench/services/query/common/queryRunner';
 import { ChartOptions, IChartOption, ControlType } from './chartOptions';
-import { Extensions, IInsightRegistry } from 'sql/platform/dashboard/browser/insightRegistry';
-import { IInsightData } from './interfaces';
+import { Extensions, IInsightRegistry, IInsightData } from 'sql/platform/dashboard/browser/insightRegistry';
 import { Registry } from 'vs/platform/registry/common/platform';
 import * as DOM from 'vs/base/browser/dom';
 import { SelectBox } from 'sql/base/browser/ui/selectBox/selectBox';

src/sql/workbench/contrib/charts/browser/countInsight.ts

@@ -5,10 +5,11 @@
 
 import 'vs/css!./media/countInsight';
 
-import { IInsight, IInsightData } from './interfaces';
+import { IInsight } from './interfaces';
 
 import { $, clearNode } from 'vs/base/browser/dom';
 import { InsightType } from 'sql/workbench/contrib/charts/common/interfaces';
+import { IInsightData } from 'sql/platform/dashboard/browser/insightRegistry';
 
 export class CountInsight implements IInsight {
 	public options;

src/sql/workbench/contrib/charts/browser/graphInsight.ts

@@ -11,10 +11,11 @@ import * as colors from 'vs/platform/theme/common/colorRegistry';
 import { editorLineNumbers } from 'vs/editor/common/view/editorColorRegistry';
 import { IThemeService, ITheme } from 'vs/platform/theme/common/themeService';
 
-import { IInsight, IInsightData, IPointDataSet, customMixin } from './interfaces';
+import { IInsight, IPointDataSet, customMixin } from './interfaces';
 import { IInsightOptions, DataDirection, ChartType, LegendPosition, DataType } from 'sql/workbench/contrib/charts/common/interfaces';
 import { values } from 'vs/base/common/collections';
 import { find } from 'vs/base/common/arrays';
+import { IInsightData } from 'sql/platform/dashboard/browser/insightRegistry';
 
 const noneLineGraphs = [ChartType.Doughnut, ChartType.Pie];
 

src/sql/workbench/contrib/charts/browser/imageInsight.ts

@@ -3,13 +3,14 @@
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { IInsight, IInsightData } from './interfaces';
+import { IInsight } from './interfaces';
 import { INotificationService } from 'vs/platform/notification/common/notification';
 import { $ } from 'vs/base/browser/dom';
 import { mixin } from 'vs/base/common/objects';
 import { IInsightOptions, InsightType } from 'sql/workbench/contrib/charts/common/interfaces';
 import * as nls from 'vs/nls';
 import { startsWith } from 'vs/base/common/strings';
+import { IInsightData } from 'sql/platform/dashboard/browser/insightRegistry';
 
 export interface IConfig extends IInsightOptions {
 	encoding?: string;

src/sql/workbench/contrib/charts/browser/insight.ts

@@ -6,7 +6,7 @@
 import { Graph } from './graphInsight';
 import { ImageInsight } from './imageInsight';
 import { TableInsight } from './tableInsight';
-import { IInsight, IInsightCtor, IInsightData } from './interfaces';
+import { IInsight, IInsightCtor } from './interfaces';
 import { CountInsight } from './countInsight';
 
 import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
@@ -14,6 +14,7 @@ import { Dimension, clearNode } from 'vs/base/browser/dom';
 import { deepClone } from 'vs/base/common/objects';
 import { IInsightOptions, ChartType, DataDirection, InsightType } from 'sql/workbench/contrib/charts/common/interfaces';
 import { find } from 'vs/base/common/arrays';
+import { IInsightData } from 'sql/platform/dashboard/browser/insightRegistry';
 
 const defaultOptions: IInsightOptions = {
 	type: ChartType.Bar,

src/sql/workbench/contrib/charts/browser/interfaces.ts

@@ -7,6 +7,7 @@ import { Dimension } from 'vs/base/browser/dom';
 import { mixin } from 'sql/base/common/objects';
 import * as types from 'vs/base/common/types';
 import { IInsightOptions, InsightType, ChartType } from 'sql/workbench/contrib/charts/common/interfaces';
+import { IInsightData } from 'sql/platform/dashboard/browser/insightRegistry';
 
 export interface IPointDataSet {
 	data: Array<{ x: number | string, y: number }>;
@@ -32,11 +33,6 @@ export function customMixin(destination: any, source: any, overwrite?: boolean):
 	return destination;
 }
 
-export interface IInsightData {
-	columns: Array<string>;
-	rows: Array<Array<string>>;
-}
-
 export interface IInsight {
 	options: IInsightOptions;
 	data: IInsightData;

src/sql/workbench/contrib/charts/browser/tableInsight.ts

@@ -3,7 +3,7 @@
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { IInsight, IInsightData } from './interfaces';
+import { IInsight } from './interfaces';
 import { TableDataView } from 'sql/base/browser/ui/table/tableDataView';
 import { Table } from 'sql/base/browser/ui/table/table';
 import { attachTableStyler } from 'sql/platform/theme/common/styler';
@@ -13,6 +13,7 @@ import { $, Dimension } from 'vs/base/browser/dom';
 import { Disposable } from 'vs/base/common/lifecycle';
 import { IThemeService } from 'vs/platform/theme/common/themeService';
 import { InsightType } from 'sql/workbench/contrib/charts/common/interfaces';
+import { IInsightData } from 'sql/platform/dashboard/browser/insightRegistry';
 
 export class TableInsight extends Disposable implements IInsight {
 	public static readonly types = [InsightType.Table];