From 56c989ac7b7fe9c1d94ba8a25aa68ba5d5a27d33 Mon Sep 17 00:00:00 2001 From: Lucy Zhang Date: Fri, 25 Sep 2020 12:49:42 -0700 Subject: [PATCH] Fix notebook toolbar screen reader reading order (#12252) * add presentation role to selectContainer * make nb toolbar dropdown arrow unfocusable * remove empty string content change --- src/sql/base/browser/ui/selectBox/selectBox.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/sql/base/browser/ui/selectBox/selectBox.ts b/src/sql/base/browser/ui/selectBox/selectBox.ts index 8631deb5b7..5a6fd9c886 100644 --- a/src/sql/base/browser/ui/selectBox/selectBox.ts +++ b/src/sql/base/browser/ui/selectBox/selectBox.ts @@ -336,6 +336,7 @@ export class SelectBox extends vsSelectBox { if (selectOptions && selectOptions.labelText && selectOptions.labelText !== undefined) { let outerContainer = document.createElement('div'); let selectContainer = document.createElement('div'); + selectContainer.setAttribute('role', 'presentation'); outerContainer.className = selectOptions.labelOnTop ? 'labelOnTopContainer' : 'labelOnLeftContainer';