ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Don't capture query history events until service is started (#13983)

Browse Source
This commit is contained in:
Charles Gagnon
2021-01-15 12:54:29 -08:00
committed by GitHub
parent 7a0a56df2f
commit 5810623e55
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/sql/workbench/services/queryHistory/common/queryHistoryServiceImpl.ts
View File

@@ -26,6 +26,8 @@ export class QueryHistoryService extends Disposable implements IQueryHistoryServ
private _onInfosUpdated: Emitter<QueryHistoryInfo[]> = new Emitter<QueryHistoryInfo[]>(); private _onInfosUpdated: Emitter<QueryHistoryInfo[]> = new Emitter<QueryHistoryInfo[]>();
private _onQueryHistoryCaptureChanged: Emitter<boolean> = new Emitter<boolean>(); private _onQueryHistoryCaptureChanged: Emitter<boolean> = new Emitter<boolean>();
private _captureEnabled: boolean; private _captureEnabled: boolean;
private _started: boolean = false;
// EVENTS ////////////////////////////////////////////////////////////// // EVENTS //////////////////////////////////////////////////////////////
public get onInfosUpdated(): Event<QueryHistoryInfo[]> { return this._onInfosUpdated.event; } public get onInfosUpdated(): Event<QueryHistoryInfo[]> { return this._onInfosUpdated.event; }
public get onQueryHistoryCaptureChanged(): Event<boolean> { return this._onQueryHistoryCaptureChanged.event; } public get onQueryHistoryCaptureChanged(): Event<boolean> { return this._onQueryHistoryCaptureChanged.event; }
@@ -38,7 +40,7 @@ export class QueryHistoryService extends Disposable implements IQueryHistoryServ
) { ) {
super(); super();
this._captureEnabled = !!this._configurationService.getValue<boolean>('queryHistory.captureEnabled'); this.updateCaptureEnabled();
this._register(this._configurationService.onDidChangeConfiguration((e: IConfigurationChangeEvent) => { this._register(this._configurationService.onDidChangeConfiguration((e: IConfigurationChangeEvent) => {
if (e.affectedKeys.find(x => x === 'queryHistory.captureEnabled')) { if (e.affectedKeys.find(x => x === 'queryHistory.captureEnabled')) {
@@ -117,7 +119,7 @@ export class QueryHistoryService extends Disposable implements IQueryHistoryServ
private updateCaptureEnabled(): void { private updateCaptureEnabled(): void {
const currentCaptureEnabled = this._captureEnabled; const currentCaptureEnabled = this._captureEnabled;
this._captureEnabled = !!this._configurationService.getValue<boolean>('queryHistory.captureEnabled'); this._captureEnabled = !!this._configurationService.getValue<boolean>('queryHistory.captureEnabled') && this._started;
if (currentCaptureEnabled !== this._captureEnabled) { if (currentCaptureEnabled !== this._captureEnabled) {
this._onQueryHistoryCaptureChanged.fire(this._captureEnabled); this._onQueryHistoryCaptureChanged.fire(this._captureEnabled);
} }
@@ -127,6 +129,7 @@ export class QueryHistoryService extends Disposable implements IQueryHistoryServ
* Method to force initialization of the service so that it can start tracking query events * Method to force initialization of the service so that it can start tracking query events
*/ */
public start(): void { public start(): void {
this._started = true;
this.updateCaptureEnabled();
} }
} }