From 58763a2b7035fdfa2c942884292c2ebd1756cc9a Mon Sep 17 00:00:00 2001 From: Karl Burtram Date: Sat, 16 Dec 2017 00:56:25 -0800 Subject: [PATCH] Fix broken Help menu items (#334) --- scripts/code.sh | 0 scripts/watch.sh | 0 src/vs/code/electron-main/menus.ts | 8 ++++++-- 3 files changed, 6 insertions(+), 2 deletions(-) mode change 100644 => 100755 scripts/code.sh mode change 100644 => 100755 scripts/watch.sh diff --git a/scripts/code.sh b/scripts/code.sh old mode 100644 new mode 100755 diff --git a/scripts/watch.sh b/scripts/watch.sh old mode 100644 new mode 100755 diff --git a/src/vs/code/electron-main/menus.ts b/src/vs/code/electron-main/menus.ts index 742ec9c19e..1890459626 100644 --- a/src/vs/code/electron-main/menus.ts +++ b/src/vs/code/electron-main/menus.ts @@ -981,8 +981,12 @@ export class CodeMenu { arrays.coalesce([ // new MenuItem({ label: mnemonicLabel(nls.localize({ key: 'miWelcome', comment: ['&& denotes a mnemonic'] }, "&&Welcome")), click: () => this.windowsService.sendToFocused('vscode:runAction', 'workbench.action.showWelcomePage') }), // {{SQL CARBON EDIT}} - product.releaseNotesUrl ? new MenuItem({ label: this.mnemonicLabel(nls.localize({ key: 'miReleaseNotes', comment: ['&& denotes a mnemonic'] }, "Getting &&Started")), click: () => this.windowsService.sendToFocused('vscode:runAction', 'update.showCurrentCarbonReleaseNotes') }) : null, - product.documentationUrl ? new MenuItem({ label: this.mnemonicLabel(nls.localize({ key: 'miDocumentation', comment: ['&& denotes a mnemonic'] }, "&&Documentation")), click: () => this.windowsService.sendToFocused('vscode:runAction', 'workbench.action.openDocumentationUrl') }) : null, + product.releaseNotesUrl ? + this.createMenuItem(nls.localize({ key: 'miReleaseNotes', comment: ['&& denotes a mnemonic'] }, "Getting &&Started"), 'update.showCurrentCarbonReleaseNotes') + : null, + product.documentationUrl ? + this.createMenuItem(nls.localize({ key: 'miDocumentation', comment: ['&& denotes a mnemonic'] }, "&&Documentation"), 'workbench.action.openDocumentationUrl') + : null, // __separator__(), // keyboardShortcutsUrl ? new MenuItem({ label: mnemonicLabel(nls.localize({ key: 'miKeyboardShortcuts', comment: ['&& denotes a mnemonic'] }, "&&Keyboard Shortcuts Reference")), click: () => this.windowsService.sendToFocused('vscode:runAction', 'workbench.action.keybindingsReference') }) : null, // product.introductoryVideosUrl ? new MenuItem({ label: mnemonicLabel(nls.localize({ key: 'miIntroductoryVideos', comment: ['&& denotes a mnemonic'] }, "Introductory &&Videos")), click: () => this.windowsService.sendToFocused('vscode:runAction', 'workbench.action.openIntroductoryVideosUrl') }) : null,