Large cleanup of AzureCore - Introduction of getAccountSecurityToken and deprecation of getSecurityToken (#11446)

* do a large cleanup of azurecore

* Fix tests

* Rework Device Code

* Fix tests

* Fix AE scenario

* Fix firewall rule - clenaup logging

* Shorthand syntax

* Fix firewall tests

* Start on tests for azureAuth

* Add more tests

* Address comments

* Add a few more important tests

* Don't throw error on old code

* Fill in todo

src/sql/azdata.d.ts

@@ -2131,9 +2131,18 @@ declare module 'azdata' {
 		 * @param account Account to generate security token for (defaults to
 		 * AzureResource.ResourceManagement if not given)
 		 * @return Promise to return the security token
+		 * @deprecated use getAccountSecurityToken
 		 */
 		export function getSecurityToken(account: Account, resource?: AzureResource): Thenable<{ [key: string]: any }>;
 
+		/**
+		 * Generates a security token by asking the account's provider
+		 * @param account
+		 * @param tenant
+		 * @param resource
+		 */
+		export function getAccountSecurityToken(account: Account, tenant: string, resource: AzureResource): Thenable<{ token: string, tokenType?: string } | undefined>;
+
 		/**
 		 * An [event](#Event) which fires when the accounts have changed.
 		 */
@@ -2279,6 +2288,7 @@ declare module 'azdata' {
 		 * @param account The account to generate a security token for
 		 * @param resource The resource to get the token for
 		 * @return Promise to return a security token object
+		 * @deprecated use getAccountSecurityToken
 		 */
 		getSecurityToken(account: Account, resource: AzureResource): Thenable<{} | undefined>;