From 58d0add46f438b080ad31c19fa5afb0533898e40 Mon Sep 17 00:00:00 2001 From: Vasu Bhog Date: Tue, 13 Apr 2021 17:28:33 -0700 Subject: [PATCH] Save Kusto Notebook with proper language notebook info (#15113) * save kusto language info --- .../notebook/browser/models/notebookModel.ts | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/sql/workbench/services/notebook/browser/models/notebookModel.ts b/src/sql/workbench/services/notebook/browser/models/notebookModel.ts index f642b87cf4..ac7cf68265 100644 --- a/src/sql/workbench/services/notebook/browser/models/notebookModel.ts +++ b/src/sql/workbench/services/notebook/browser/models/notebookModel.ts @@ -963,12 +963,15 @@ export class NotebookModel extends Disposable implements INotebookModel { private async updateKernelInfoOnKernelChange(kernel: nb.IKernel, kernelAlias?: string) { await this.updateKernelInfo(kernel); - this.kernelAliases.forEach(kernel => { - if (this._defaultLanguageInfo?.name === kernel.toLowerCase()) { - kernelAlias = kernel; - } - }); - if (kernel.info) { + kernelAlias = this.kernelAliases.find(kernel => this._defaultLanguageInfo?.name === kernel.toLowerCase()) ?? kernelAlias; + if (kernelAlias) { + let aliasLanguageInfo: nb.ILanguageInfo = { + name: kernelAlias.toLowerCase(), + version: '' + }; + this.updateLanguageInfo(aliasLanguageInfo); + } + else if (kernel.info) { this.updateLanguageInfo(kernel.info.language_info); } this.adstelemetryService.createActionEvent(TelemetryKeys.TelemetryView.Notebook, TelemetryKeys.NbTelemetryAction.KernelChanged)