ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-03-28 07:40:30 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix #3778 intellisense is delayed (#4134)

Browse Source 
- Jupyter completion item support was awaiting info before responding. Fix is to check if this is even a notebook cell first, then only await stuff if that's true
This commit is contained in:
Kevin Cunnane
2019-02-22 16:22:40 -08:00
committed by GitHub
parent da3fbd386d
commit 5a88598811
3 changed files with 36 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/notebook/src/jupyter/jupyterNotebookProvider.ts
View File

@@ -27,10 +27,10 @@ export class JupyterNotebookProvider implements nb.NotebookProvider {
if (!notebookUri) {
return Promise.reject(localize('errNotebookUriMissing', 'A notebook path is required'));
}
return this.doGetNotebookManager(notebookUri);
return Promise.resolve(this.doGetNotebookManager(notebookUri));
}
private doGetNotebookManager(notebookUri: vscode.Uri): Promise<nb.NotebookManager> {
private doGetNotebookManager(notebookUri: vscode.Uri): nb.NotebookManager {
let uriString = notebookUri.toString();
let manager = this.managerTracker.get(uriString);
if (!manager) {
@@ -38,7 +38,7 @@ export class JupyterNotebookProvider implements nb.NotebookProvider {
manager = new JupyterNotebookManager(serverManager);
this.managerTracker.set(uriString, manager);
}
return Promise.resolve(manager);
return manager;
}
handleNotebookClosed(notebookUri: vscode.Uri): void {