Ensure SQL is the first kernel in the kernels dropdown (#4692)

* Ensure SQL is the first kernel shown in the dropdown

* cleanup to prevent sql from registering twice
This commit is contained in:
Chris LaFreniere
2019-03-26 19:39:28 -07:00
committed by GitHub
parent d6a58136da
commit 5ac6cf3b74

View File

@@ -109,14 +109,17 @@ export class NotebookService extends Disposable implements INotebookService {
super();
this._memento = new Memento('notebookProviders', this._storageService);
this._register(notebookRegistry.onNewRegistration(this.updateRegisteredProviders, this));
this.registerBuiltInProvider();
// If a provider has been already registered, the onNewRegistration event will not have a listener attached yet
// So, explicitly updating registered providers here.
if (notebookRegistry.providers.length > 0) {
notebookRegistry.providers.forEach(p => {
this.updateRegisteredProviders({id: p.provider, registration: p});
// Don't need to re-register SQL_NOTEBOOK_PROVIDER
if (p.provider !== SQL_NOTEBOOK_PROVIDER) {
this.updateRegisteredProviders({id: p.provider, registration: p});
}
});
}
this.registerBuiltInProvider();
if (extensionService) {
extensionService.whenInstalledExtensionsRegistered().then(() => {