ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix stdin cancel breaks notebook (#8012)

Browse Source
This commit is contained in:
Chris LaFreniere
2019-10-25 10:52:18 -07:00
committed by GitHub
parent b65a7795df
commit 5b29aef5f3
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/sql/workbench/parts/notebook/browser/models/cell.ts
View File

@@ -311,6 +311,10 @@ export class CellModel implements ICellModel {
// If cell is currently running and user clicks the stop/cancel button, call kernel.interrupt() // If cell is currently running and user clicks the stop/cancel button, call kernel.interrupt()
// This matches the same behavior as JupyterLab // This matches the same behavior as JupyterLab
if (this.future && this.future.inProgress) { if (this.future && this.future.inProgress) {
// If stdIn is visible, to prevent a kernel hang, we need to send a dummy input reply
if (this._stdInVisible && this._stdInHandler) {
this.future.sendInputReply({ value: '' });
}
this.future.inProgress = false; this.future.inProgress = false;
await kernel.interrupt(); await kernel.interrupt();
this.sendNotification(notificationService, Severity.Info, localize('runCellCancelled', "Cell execution cancelled")); this.sendNotification(notificationService, Severity.Info, localize('runCellCancelled', "Cell execution cancelled"));